Page MenuHomeFreeBSD

Eliminate lock recursion from turnstiles.
ClosedPublic

Authored by jeff on Dec 10 2019, 6:16 AM.
Tags
None
Referenced Files
F172808737: D22746.diff
Mon, Sep 21, 4:10 AM
Unknown Object (File)
Fri, Sep 18, 12:14 PM
Unknown Object (File)
Mon, Sep 14, 3:11 PM
Unknown Object (File)
Thu, Sep 10, 6:30 PM
Unknown Object (File)
Mon, Sep 7, 8:05 PM
Unknown Object (File)
Fri, Sep 4, 10:14 PM
Unknown Object (File)
Fri, Sep 4, 5:19 PM
Unknown Object (File)
Fri, Sep 4, 3:57 PM
Subscribers

Details

Summary

This avoids the one place we recursively lock turnstiles. In highly contended workloads the recursive locking actually imposes a performance penalty. We trade failed atomic cmpsets and multiple modifications to the lock cacheline for a few pointer comparisons.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28055
Build 26203: arc lint + arc unit

Event Timeline

jeff added reviewers: jhb, kib, mav.
jeff set the repository for this revision to rS FreeBSD src repository - subversion.
This revision is now accepted and ready to land.Dec 10 2019, 2:42 PM
This revision was automatically updated to reflect the committed changes.
jeff added a commit: rS355782: schedlock 3/4.