Page MenuHomeFreeBSD

Eliminate lock recursion from turnstiles.
ClosedPublic

Authored by jeff on Dec 10 2019, 6:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 31, 12:39 AM
Unknown Object (File)
Jan 11 2025, 7:50 AM
Unknown Object (File)
Nov 26 2024, 7:13 AM
Unknown Object (File)
Nov 26 2024, 12:21 AM
Unknown Object (File)
Nov 22 2024, 3:04 PM
Unknown Object (File)
Oct 19 2024, 1:06 PM
Unknown Object (File)
Oct 19 2024, 1:06 PM
Unknown Object (File)
Oct 19 2024, 1:06 PM
Subscribers

Details

Summary

This avoids the one place we recursively lock turnstiles. In highly contended workloads the recursive locking actually imposes a performance penalty. We trade failed atomic cmpsets and multiple modifications to the lock cacheline for a few pointer comparisons.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28055
Build 26203: arc lint + arc unit

Event Timeline

jeff added reviewers: jhb, kib, mav.
jeff set the repository for this revision to rS FreeBSD src repository - subversion.
This revision is now accepted and ready to land.Dec 10 2019, 2:42 PM
This revision was automatically updated to reflect the committed changes.
jeff added a commit: rS355782: schedlock 3/4.