Differential D22746

Eliminate lock recursion from turnstiles.
ClosedPublic
Actions

Authored by jeff on Dec 10 2019, 6:16 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jul 1, 10:31 AM

	Unknown Object (File)
	Mon, Jun 30, 5:21 AM

	Unknown Object (File)
	Fri, Jun 27, 9:04 AM

	Unknown Object (File)
	Wed, Jun 25, 3:09 AM

	Unknown Object (File)
	Mon, Jun 23, 3:41 AM

	Unknown Object (File)
	Sat, Jun 21, 11:20 PM

	Unknown Object (File)
	Fri, Jun 20, 9:02 PM

	Unknown Object (File)
	Thu, Jun 19, 8:33 AM

View All 71 Files

Subscribers

Details

Reviewers

jhb
kib
mav

Commits

rS355782: schedlock 3/4

Summary

This avoids the one place we recursively lock turnstiles. In highly contended workloads the recursive locking actually imposes a performance penalty. We trade failed atomic cmpsets and multiple modifications to the lock cacheline for a few pointer comparisons.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28055
Build 26203: arc lint + arc unit

Event Timeline

jeff created this revision.Dec 10 2019, 6:16 AM

Harbormaster completed remote builds in B28055: Diff 65449.Dec 10 2019, 6:16 AM

jeff edited the summary of this revision. (Show Details)Dec 10 2019, 6:21 AM

jeff added reviewers: jhb, kib, mav.

jeff set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptDec 10 2019, 6:21 AM

kib accepted this revision.Dec 10 2019, 2:42 PM

This revision is now accepted and ready to land.Dec 10 2019, 2:42 PM

Closed by commit rS355782: schedlock 3/4 (authored by jeff). · Explain WhyDec 15 2019, 9:20 PM

This revision was automatically updated to reflect the committed changes.

jeff added a commit: rS355782: schedlock 3/4.

Revision Contents
Changeset List

Path

Size

sys/

kern/

subr_turnstile.c

50 lines

Diff 65449

sys/kern/subr_turnstile.c

Loading...