Details

Reviewers

Group Reviewers

Commits

rP522484: Add QA warning about useless REINPLACE_CMD

Summary

There are many places in ports where REINPLACE_CMD is used but doesn't do anything. It's a frequent source of issues. This adds way to check that the REINPLACE_CMD made a change and complain about it if not.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

swills created this revision.Oct 29 2019, 4:12 PM

Harbormaster completed remote builds in B27262: Diff 63759.Oct 29 2019, 4:12 PM

swills retitled this revision from check for REINPLACE_CMD usage that doesn't do anything to WIP: check for REINPLACE_CMD usage that doesn't do anything.Oct 29 2019, 4:22 PM

bdrewery added a subscriber: bdrewery.Oct 29 2019, 10:55 PM

bdrewery added inline comments.

Tools/scripts/sed_checked.sh
9	`[ -f $blah ]` doesn't generate output so the redirections aren't needed.
10–17	You quoted the first `if [ -f` but then lost quotes everywhere else. It will be significant with filenames with spaces or globbing characters. Unlikely but trivial to avoid the problem.

bdrewery added inline comments.Oct 29 2019, 10:56 PM

Mk/bsd.port.mk
2016	Is there a review dependency missing here? I'm not sure what `FRAMEWORK_REINPLACE_CMD` is.

Updated WIP

Herald added a reviewer: portmgr. · View Herald TranscriptOct 30 2019, 1:49 AM

I had added FRAMEWORK_REINPLACE_CMD as a way to avoid warnings from REINPLACE_CMD but haven't submitted a review for it yet because I'm not sure it's needed if this is going to just be a warning. But if you want, see:

https://reviews.freebsd.org/differential/diff/63739/

Thanks for taking a look, I think the other comments should be addressed. Better, but still needs work.

mat added a subscriber: mat.Nov 5 2019, 11:42 AM

mat added inline comments.

Mk/bsd.port.mk
1621–1622	Why add WRKDIR and WRKSRC, it is not using it.
2012	REWARNFILE should be defined once and not have magic values here and there :-)
Tools/scripts/sed_checked.sh
9–10	if !cmp "${x}" "${x}".bak > /dev/null 2>&1; then (or maybe without the `!`, not sure)

Address comments from @mat

swills marked an inline comment as done.Nov 6 2019, 9:30 PM

swills marked an inline comment as done.

Fix braino

swills marked an inline comment as done.Nov 7 2019, 9:46 PM

In my testing, this finds a large number of errors and of various types. The only issue I've found with it so far is places were we replace /usr/local with LOCALBASE or PREFIX which is also /usr/local, which produces a false alarm from this script. On the other hand, it finds a large number of real problems of various types. One example is this:

https://svnweb.freebsd.org/ports/head/print/alignmargins/files/patch-alignmargins?r1=127541&r2=127691

where the committer accidentally changed LOCALBASE to /usr/local, and no one has noticed for 14 years. Another is sysutils/and which patches a file then calls REINPLACE_CMD on it to replace what it patched into the file. And another is www/amphetadesk which calls REINPLACE_CMD on every file in WRKSRC, including images.

So I do find this to be a really useful check and would like to commit it soon.

mat added inline comments.Nov 13 2019, 2:40 PM

Mk/Scripts/qa.sh
5–6	Not sure this change is needed. We're only checking for the 3 most important variables. And even then, qa.sh is only run from one place, where those three variables are always defined. In any way, REWARNFILE is always added to the environment in bsd.port.mk, so I feel this is not needed.
Tools/scripts/sed_checked.sh
7	cmp as a silent mode: if cmp -s "${x}" "${x}".bak ; then

swills updated this revision to Diff 64329.Nov 14 2019, 4:38 PM

swills marked an inline comment as done.

tobik added a subscriber: tobik.Dec 5 2019, 4:09 PM

tobik added inline comments.

Tools/scripts/sed_checked.sh
4	This script always has exit status 0 which means that the blackbox behavior now differs when DEVELOPER is set and when it is not. If I introduce a syntax error in a sed expression the build will continue unpatched anyway when it probably should abort like before. Maybe add `set -e` or `\|\| exit 1` to the script or handle the error case in some other way.
9	Every file flagged here will always be prefixed with ${WRKDIR} which seems redundant. WRKDIR can also be a pretty long path. Would it make sense to strip it like what is done in the shebang and symlink checks in qa.sh?