Paths

Table of Contentst

Differential D22731

Handle pagein clustering for vm_page_grab_valid() so that exec can use it.
ClosedPublic
Actions

Authored by jeff on Dec 8 2019, 2:06 AM.

Tags

None

Referenced Files

	F168811637: D22731.id.diff
	Sun, Aug 30, 6:43 AM

	F168804491: D22731.diff
	Sun, Aug 30, 6:05 AM

	Unknown Object (File)
	Sat, Aug 29, 1:07 AM

	Unknown Object (File)
	Wed, Aug 19, 6:41 AM

	Unknown Object (File)
	Tue, Aug 18, 8:22 PM

	Unknown Object (File)
	Tue, Aug 18, 8:02 PM

	Unknown Object (File)
	Tue, Aug 18, 4:17 PM

	Unknown Object (File)
	Tue, Aug 18, 3:48 PM

Subscribers

Details

Reviewers

alc
dougm
kib
markj

Commits

rS355763: Handle pagein clustering in vm_page_grab_valid() so that it can be used by

Summary

This should be a functional NOP. It will allow for other vm_page_grab_valid() consumers to prefetch pages but more importantly it decreases the surface area for upcoming changes and reduces the amount of complicated VM code floating around in kern/*.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28037
Build 26188: arc lint + arc unit

Event Timeline

jeff created this revision.Dec 8 2019, 2:06 AM

Harbormaster completed remote builds in B28037: Diff 65397.Dec 8 2019, 2:06 AM

jeff edited the summary of this revision. (Show Details)Dec 8 2019, 2:10 AM

jeff added reviewers: alc, dougm, kib, markj.

jeff set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptDec 8 2019, 2:10 AM

kib accepted this revision.Dec 8 2019, 5:47 PM

This revision is now accepted and ready to land.Dec 8 2019, 5:47 PM

alc added inline comments.Dec 9 2019, 4:32 PM

sys/vm/vm_page.c
4340–4342	This needs to say that flags, like VM_ALLOC_WIRED, won't affect the additional pages. It's not going to be obvious to everyone.

alc added inline comments.Dec 9 2019, 4:37 PM

sys/kern/kern_exec.c
996	`error != VM_PAGER_OK`

Closed by commit rS355763: Handle pagein clustering in vm_page_grab_valid() so that it can be used by (authored by jeff). · Explain WhyDec 15 2019, 2:00 AM

This revision was automatically updated to reflect the committed changes.

jeff added a commit: rS355763: Handle pagein clustering in vm_page_grab_valid() so that it can be used by.

Revision Contents
Changeset List

Path

Size

sys/

kern/

72 lines

vm/

41 lines

Diff 65397

sys/kern/kern_exec.c

Loading...

sys/vm/vm_page.c

Loading...