Page MenuHomeFreeBSD

Fix fault_type handling in vm_map_lookup().
ClosedPublic

Authored by markj on Dec 4 2019, 8:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Aug 13, 7:50 PM
Unknown Object (File)
Tue, Aug 11, 6:03 PM
Unknown Object (File)
Mon, Aug 10, 3:10 PM
Unknown Object (File)
Sun, Aug 9, 12:46 PM
Unknown Object (File)
Fri, Aug 7, 3:53 PM
Unknown Object (File)
Jul 21 2026, 5:40 AM
Unknown Object (File)
May 9 2026, 1:43 AM
Unknown Object (File)
May 8 2026, 7:52 PM
Subscribers

Details

Summary

Suppose that the map entry is wired, so that we later assign
fault_type = entry->protection. Suppose further that we jump back to
RetryLookup. Then fault_type will no longer contain the original
fault protection mask.

I think this is mostly harmless from a correctness standpoint. We end
up with a fault_type that is a superset of its correct value. We may
trigger a copy-on-write update to the entry while handling a read fault,
or we may end up returning KERN_PROTECTION_FAILURE for a fault that
should have succeeded if the entry protections change while the map lock
was dropped.

Submitted by: Wuyang Chung <wuyang.chung1@gmail.com>

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 27963
Build 26129: arc lint + arc unit