Fix the signature for zone_import and zone_release
ClosedPublic
Actions

Authored by andrew on Dec 4 2019, 2:52 PM.

Details

Reviewers

markj
kib
jeff
rlibby

Commits

rS355398: Fix the signature for zone_import and zone_release

Summary

These are cast to uma_import and uma_release functions. Use the signature
for these in the zone fucntions.

This was found with an experimental Kernel CFI. It will complaid if the
signature is different than what a function pointer expects. The
simplest way to fix these is to correct the signature.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 27936
Build 26102: arc lint + arc unit

Event Timeline

andrew created this revision.Dec 4 2019, 2:52 PM

Harbormaster completed remote builds in B27936: Diff 65208.Dec 4 2019, 2:52 PM

Looks fine.

Is this going to identify all casting of function pointers? These ones
here seem pretty innocuous.

This revision is now accepted and ready to land.Dec 4 2019, 4:53 PM

It will find all pointers that are used, however I exclude a few functions that may call different, but compatible types e.g. SYSINITS should be void func(const void *), but many don't include the const so I mark mi_startup with a no-cfi attribute.