mips busdma: bzero map on alloc
ClosedPublic
Actions

Authored by rlibby on Dec 3 2019, 6:55 AM.

Details

Reviewers

imp
• ian

Commits

rS355343: mips busdma: bzero map on alloc

Summary

Maps from the mips busdma dmamap_zone were not completely initialized.
In particular, pagesneeded and pagesreserved were not initialized. This
could cause a crash.

Remove some dead fields from mips struct bus_dmamap while here.

Reported by: brooks

Test Plan

make CROSS_TOOLCHAIN=mips64-gcc TARGET_ARCH=mips64 buildkernel KERNCONF=MALTA64
qemu-system-mips64 -M malta -kernel .../mips.mips64/sys/MALTA64/kernel -m 2048 -nographic

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rlibby created this revision.Dec 3 2019, 6:55 AM

Harbormaster completed remote builds in B27903: Diff 65150.Dec 3 2019, 6:55 AM

Heh, looks like when this code was copied to mips, someone ignored my comment

It'll need platform-specific changes if this code is copied.

This revision is now accepted and ready to land.Dec 3 2019, 4:13 PM

Closed by commit rS355343: mips busdma: bzero map on alloc (authored by rlibby). · Explain WhyDec 3 2019, 5:44 PM

This revision was automatically updated to reflect the committed changes.

rlibby added a commit: rS355343: mips busdma: bzero map on alloc.

Revision Contents
Changeset List

Path

Size

head/

sys/

mips/

busdma_machdep.c

7 lines

Diff 65167

View Options

head/sys/mips/mips/busdma_machdep.c

	Show First 20 Lines • Show All 653 Lines • ▼ Show 20 Lines
	#define AUE_SEMWAIT 43258 /* FreeBSD-specific. */			#define AUE_SEMWAIT 43258 /* FreeBSD-specific. */
	#define AUE_FGETUUID 43259 /* CADETS. */			#define AUE_FGETUUID 43259 /* CADETS. */
	#define AUE_GETUUID 43260 /* CADETS. */			#define AUE_GETUUID 43260 /* CADETS. */
	#define AUE_LGETUUID 43261 /* CADETS. */			#define AUE_LGETUUID 43261 /* CADETS. */
	#define AUE_EXECVEAT 43262 /* FreeBSD/Linux. */			#define AUE_EXECVEAT 43262 /* FreeBSD/Linux. */
	#define AUE_SHMRENAME 43263 /* FreeBSD-specific. */			#define AUE_SHMRENAME 43263 /* FreeBSD-specific. */
	#define AUE_REALPATHAT 43264 /* FreeBSD-specific. */			#define AUE_REALPATHAT 43264 /* FreeBSD-specific. */
	#define AUE_CLOSERANGE 43265 /* FreeBSD-specific. */			#define AUE_CLOSERANGE 43265 /* FreeBSD-specific. */
				#define AUE_AIO_WRITEV 43266 /* FreeBSD-specific. */
				#define AUE_AIO_READV 43267 /* FreeBSD-specific. */

	/*			/*
	* Darwin BSM uses a number of AUE_O_* definitions, which are aliased to the			* Darwin BSM uses a number of AUE_O_* definitions, which are aliased to the
	* normal Solaris BSM identifiers. _O_ refers to it being an old, or compat			* normal Solaris BSM identifiers. _O_ refers to it being an old, or compat
	* interface. In most cases, Darwin has never implemented these system calls			* interface. In most cases, Darwin has never implemented these system calls
	* but picked up the fields in their system call table from their FreeBSD			* but picked up the fields in their system call table from their FreeBSD
	* import. Happily, these have different names than the AUE_O* definitions			* import. Happily, these have different names than the AUE_O* definitions
	* in Solaris BSM.			* in Solaris BSM.
	▲ Show 20 Lines • Show All 179 Lines • Show Last 20 Lines

mips busdma: bzero map on allocClosedPublicActions