Fix a logic bug when "mask: contains a ?: operator.
ClosedPublic
Actions

Authored by brooks on Nov 27 2019, 5:38 PM.

Tags

None

Referenced Files

	F164295074: D22573.id64950.diff
	Thu, Jul 30, 12:09 PM

	Unknown Object (File)
	Sun, Jul 19, 10:52 PM

	Unknown Object (File)
	Jun 27 2026, 8:21 PM

	Unknown Object (File)
	Jun 10 2026, 3:47 PM

	Unknown Object (File)
	May 26 2026, 9:57 AM

	Unknown Object (File)
	May 26 2026, 7:42 AM

	Unknown Object (File)
	May 26 2026, 5:00 AM

	Unknown Object (File)
	May 21 2026, 9:13 PM

View All Files

Subscribers

imp

Details

Reviewers

bz
jhb
markj

Commits

rS355454: MFC r355139:
rS355453: MFC r355139:
rS355139: Fix a logic bug when "mask" contains a ?: operator.

Summary

Newer versions of clang warn that '&' evaluates before '?:'.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 27809
Build 25988: arc lint + arc unit

Event Timeline

brooks created this revision.Nov 27 2019, 5:38 PM

Harbormaster completed remote builds in B27809: Diff 64950.Nov 27 2019, 5:38 PM

markj accepted this revision.Nov 27 2019, 6:13 PM

This revision is now accepted and ready to land.Nov 27 2019, 6:13 PM

Closed by commit rS355139: Fix a logic bug when "mask" contains a ?: operator. (authored by brooks). · Explain WhyNov 27 2019, 8:00 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rS355139: Fix a logic bug when "mask" contains a ?: operator..

Herald added a subscriber: imp. · View Herald TranscriptNov 27 2019, 8:00 PM

I would have been tempted to put parents around all macro args while l was at it...

brooks added a commit: rS355453: MFC r355139:.Dec 6 2019, 5:58 PM

brooks added a commit: rS355454: MFC r355139:.Dec 6 2019, 6:15 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

bwn/

if_bwnvar.h

2 lines

Diff 64950

View Options

Fix a logic bug when "mask: contains a ?: operator.ClosedPublicActions