Consistent vm_map_entry loop naming
ClosedPublic
Actions

Authored by dougm on Nov 20 2019, 4:31 PM.

Details

Reviewers

alc
markj

Commits

rS355076: Where 'current' is used to index over vm_map entries, use

Summary

Where 'current' is used to index over vm_map entries, use 'entry'. Where 'entry' is used to identify the starting point for iteration, use 'first_entry'. These are the naming conventions used in most of the vm_map.c code. Where VM_MAP_ENTRY_FOREACH can be used, do so. Squeeze a few lines to fit in 80 columns.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dougm created this revision.Nov 20 2019, 4:31 PM

dougm added a reviewer: markj.Nov 24 2019, 8:09 PM

markj accepted this revision.Nov 24 2019, 10:17 PM

This revision is now accepted and ready to land.Nov 24 2019, 10:17 PM

alc added inline comments.Nov 24 2019, 11:16 PM

sys/vm/vm_map.c
2521 ↗	(On Diff #64620)	Eliminate extra parens around entry->protection.
2699 ↗	(On Diff #64620)	I think that it's reasonable for this patch to wrap these lines.
3384 ↗	(On Diff #64620)	!= 0