Page MenuHomeFreeBSD

Consistent vm_map_entry loop naming
ClosedPublic

Authored by dougm on Nov 20 2019, 4:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 7, 7:57 AM
Unknown Object (File)
Thu, Jan 30, 8:03 AM
Unknown Object (File)
Thu, Jan 23, 11:10 AM
Unknown Object (File)
Tue, Jan 21, 1:19 PM
Unknown Object (File)
Dec 3 2024, 10:09 AM
Unknown Object (File)
Nov 30 2024, 3:29 AM
Unknown Object (File)
Nov 26 2024, 3:31 PM
Unknown Object (File)
Oct 19 2024, 3:30 PM
Subscribers

Details

Summary

Where 'current' is used to index over vm_map entries, use 'entry'. Where 'entry' is used to identify the starting point for iteration, use 'first_entry'. These are the naming conventions used in most of the vm_map.c code. Where VM_MAP_ENTRY_FOREACH can be used, do so. Squeeze a few lines to fit in 80 columns.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

This revision is now accepted and ready to land.Nov 24 2019, 10:17 PM
sys/vm/vm_map.c
2521–2523

Eliminate extra parens around entry->protection.

2699–2700

I think that it's reasonable for this patch to wrap these lines.

3387

!= 0

dougm marked 3 inline comments as done.
This revision now requires review to proceed.Nov 24 2019, 11:24 PM
This revision is now accepted and ready to land.Nov 24 2019, 11:27 PM