Page MenuHomeFreeBSD
Differential D22458

Consistent vm_map_entry loop naming
ClosedPublic
Actions

Authored by dougm on Nov 20 2019, 4:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 12, 12:44 PM
Unknown Object (File)
Dec 16 2025, 3:28 PM
Unknown Object (File)
Nov 25 2025, 2:57 AM
Unknown Object (File)
Nov 20 2025, 11:13 PM
Unknown Object (File)
Nov 20 2025, 11:07 PM
Unknown Object (File)
Nov 20 2025, 11:06 PM
Unknown Object (File)
Nov 20 2025, 11:03 PM
Unknown Object (File)
Nov 20 2025, 10:58 PM
View All Files
Subscribers
imp

Details

Reviewers
alc
markj
Commits
rS355076: Where 'current' is used to index over vm_map entries, use
Summary

Where 'current' is used to index over vm_map entries, use 'entry'. Where 'entry' is used to identify the starting point for iteration, use 'first_entry'. These are the naming conventions used in most of the vm_map.c code. Where VM_MAP_ENTRY_FOREACH can be used, do so. Squeeze a few lines to fit in 80 columns.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dougm created this revision.Nov 20 2019, 4:31 PM
dougm added a reviewer: markj.Nov 24 2019, 8:09 PM
markj accepted this revision.Nov 24 2019, 10:17 PM
This revision is now accepted and ready to land.Nov 24 2019, 10:17 PM
alc added inline comments.Nov 24 2019, 11:16 PM
sys/vm/vm_map.c
2521–2523

Eliminate extra parens around entry->protection.

2699–2700

I think that it's reasonable for this patch to wrap these lines.

3387

!= 0

dougm updated this revision to Diff 64836.Nov 24 2019, 11:24 PM
dougm marked 3 inline comments as done.
This revision now requires review to proceed.Nov 24 2019, 11:24 PM
alc accepted this revision.Nov 24 2019, 11:27 PM
This revision is now accepted and ready to land.Nov 24 2019, 11:27 PM
markj accepted this revision.Nov 24 2019, 11:28 PM
Closed by commit rS355076: Where 'current' is used to index over vm_map entries, use (authored by dougm). · Explain WhyNov 25 2019, 2:19 AM
This revision was automatically updated to reflect the committed changes.
dougm added a commit: rS355076: Where 'current' is used to index over vm_map entries, use.
Herald added a subscriber: imp. · View Herald TranscriptNov 25 2019, 2:19 AM

Revision Contents
Changeset List

PathSize
sys/
vm/
214 lines

Diff 64836

View Options

sys/vm/vm_map.c

Loading...