Page MenuHomeFreeBSD

Allow boostrapping xinstall on Linux
ClosedPublic

Authored by arichardson on Nov 19 2019, 5:58 PM.
Tags
None
Referenced Files
F106071677: D22446.diff
Tue, Dec 24, 10:16 PM
Unknown Object (File)
Fri, Dec 13, 5:33 PM
Unknown Object (File)
Sat, Nov 30, 9:03 AM
Unknown Object (File)
Oct 9 2024, 6:17 PM
Unknown Object (File)
Oct 7 2024, 12:49 PM
Unknown Object (File)
Oct 7 2024, 10:46 AM
Unknown Object (File)
Oct 7 2024, 5:03 AM
Unknown Object (File)
Oct 4 2024, 10:07 AM
Subscribers

Details

Summary

Linux does not have st_flags so we have to avoid using it there.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

usr.bin/xinstall/xinstall.c
83 ↗(On Diff #64580)

We're sufficiently confident that UF_SETTABLE will remain undefined on Linux? I guess it's not a big deal if this breaks and needs to be fixed, but probably worth a comment here at least.

arichardson added inline comments.
usr.bin/xinstall/xinstall.c
83 ↗(On Diff #64580)

Since this is the mask of st_flags values, I would assume support it existing implies st_flags also exists.
This was suggested by @imp in D13307.

This revision is now accepted and ready to land.Nov 20 2019, 4:14 PM
usr.bin/xinstall/xinstall.c
83 ↗(On Diff #64580)

We are as confident as we can be about Linux...

This revision was automatically updated to reflect the committed changes.