Allow boostrapping xinstall on Linux
ClosedPublic
Actions

Authored by arichardson on Nov 19 2019, 5:58 PM.

Details

Reviewers

emaste
jhb
brooks
imp

Commits

rS354901: Allow boostrapping xinstall on Linux

Summary

Linux does not have st_flags so we have to avoid using it there.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 27640
Build 25847: arc lint + arc unit

Event Timeline

arichardson created this revision.Nov 19 2019, 5:58 PM

Harbormaster completed remote builds in B27640: Diff 64580.Nov 19 2019, 5:58 PM

emaste added inline comments.Nov 19 2019, 7:29 PM

usr.bin/xinstall/xinstall.c
83	We're sufficiently confident that `UF_SETTABLE` will remain undefined on Linux? I guess it's not a big deal if this breaks and needs to be fixed, but probably worth a comment here at least.

arichardson added a subscriber: imp.Nov 19 2019, 11:19 PM

arichardson added inline comments.

usr.bin/xinstall/xinstall.c
83	Since this is the mask of st_flags values, I would assume support it existing implies st_flags also exists. This was suggested by @imp in D13307.

emaste accepted this revision.Nov 20 2019, 4:14 PM

This revision is now accepted and ready to land.Nov 20 2019, 4:14 PM

imp added inline comments.Nov 20 2019, 4:18 PM

usr.bin/xinstall/xinstall.c
83	We are as confident as we can be about Linux...

imp accepted this revision.Nov 20 2019, 4:18 PM

Closed by commit rS354901: Allow boostrapping xinstall on Linux (authored by arichardson). · Explain WhyNov 20 2019, 5:24 PM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rS354901: Allow boostrapping xinstall on Linux.

Revision Contents
Changeset List

Path

Size

usr.bin/

xinstall/

Makefile

1 line

xinstall.c

11 lines

Diff 64580

View Options

usr.bin/xinstall/Makefile