Page MenuHomeFreeBSD
Differential D2882

Reduce bqlock contention in binsfree
ClosedPublic
Actions

Authored by cse_cem_gmail_com on Jun 22 2015, 4:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 15, 5:22 AM
Unknown Object (File)
Sun, Apr 12, 5:55 AM
Unknown Object (File)
Wed, Apr 8, 1:02 AM
Unknown Object (File)
Wed, Apr 8, 12:23 AM
Unknown Object (File)
Sun, Apr 5, 2:13 PM
Unknown Object (File)
Sun, Apr 5, 1:17 PM
Unknown Object (File)
Tue, Mar 31, 7:01 AM
Unknown Object (File)
Mon, Mar 30, 6:18 AM
View All Files
Subscribers
bdrewery
benno
imp

Details

Reviewers
kib
cem
Summary

Only take 'olock' when needed for REMFREE.

Sponsored by: EMC / Isilon Storage Division

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

cse_cem_gmail_com updated this revision to Diff 6377.Jun 22 2015, 4:42 PM
cse_cem_gmail_com retitled this revision from to Reduce bqlock contention in binsfree.
cse_cem_gmail_com updated this object.
cse_cem_gmail_com edited the test plan for this revision. (Show Details)
cse_cem_gmail_com added a reviewer: kib.
cse_cem_gmail_com added subscribers: benno, bdrewery.
Herald added a subscriber: imp. · View Herald TranscriptJun 22 2015, 4:42 PM
kib edited edge metadata.Jun 22 2015, 6:00 PM

This looks fine.

sys/kern/vfs_bio.c
997

It seems you do not need to evaluate olock if B_REMFREE flag is not set.

1000

Move olock calculation there.

cse_cem_gmail_com planned changes to this revision.Jun 22 2015, 6:21 PM

Will fix.

sys/kern/vfs_bio.c
997

Sure. But it isn't expensive either:

bqlock(int qindex)
{

        if (qindex == QUEUE_DIRTY)
                return (struct mtx *)(&bqdirty);
        return (struct mtx *)(&bqclean);
}
1000

Ok.

cse_cem_gmail_com updated this revision to Diff 6380.Jun 22 2015, 6:24 PM
cse_cem_gmail_com edited edge metadata.

Move olock calculation to only where it is needed.

cse_cem_gmail_com added a comment.Jun 26 2015, 1:52 AM

Committed in r284719.

cem accepted this revision.Jul 9 2015, 10:11 PM
cem added a reviewer: cem.
This revision is now accepted and ready to land.Jul 9 2015, 10:11 PM
cem closed this revision.Jul 9 2015, 10:11 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
14 lines

Diff 6377

View Options

sys/kern/vfs_bio.c

Loading...