Page MenuHomeFreeBSD
Differential D22151

RISC-V: skip cpu-map when parsing elf_hwcap
ClosedPublic
Actions

Authored by mhorne on Oct 25 2019, 12:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 21, 12:38 AM
Unknown Object (File)
Fri, Nov 21, 12:38 AM
Unknown Object (File)
Fri, Nov 21, 12:33 AM
Unknown Object (File)
Fri, Nov 21, 12:32 AM
Unknown Object (File)
Oct 25 2025, 11:34 AM
Unknown Object (File)
Oct 24 2025, 11:50 PM
Unknown Object (File)
Oct 22 2025, 4:44 AM
Unknown Object (File)
Oct 22 2025, 4:44 AM
View All 69 Files
Subscribers
imp
markj

Details

Reviewers
markj
kp
jhb
Group Reviewers
riscv
Commits
rS354104: RISC-V: skip cpu-map when parsing elf_hwcap
Summary

The fill_elf_hwcap() function expects to find only cpu nodes under the
/cpus entry of the device tree. Newer versions of QEMU insert a cpu-map
node which describes the CPU topology, breaking this function. To fix
this, simply skip any non-cpu entries.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 27217
Build 25481: arc lint + arc unit

Event Timeline

mhorne created this revision.Oct 25 2019, 12:58 PM
Harbormaster completed remote builds in B27217: Diff 63663.Oct 25 2019, 12:58 PM
markj accepted this revision as: markj.Oct 25 2019, 2:15 PM
markj added a subscriber: markj.
markj added inline comments.
sys/riscv/riscv/identcpu.c
145

The comment should end with a period.

This revision is now accepted and ready to land.Oct 25 2019, 2:15 PM
kp accepted this revision.Oct 25 2019, 3:11 PM
jhb accepted this revision.Oct 25 2019, 5:15 PM
Closed by commit rS354104: RISC-V: skip cpu-map when parsing elf_hwcap (authored by mhorne). · Explain WhyOct 25 2019, 9:39 PM
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rS354104: RISC-V: skip cpu-map when parsing elf_hwcap.
Herald added a subscriber: imp. · View Herald TranscriptOct 25 2019, 9:39 PM

Revision Contents
Changeset List

PathSize
sys/
riscv/
riscv/
8 lines

Diff 63663

View Options

sys/riscv/riscv/identcpu.c

Loading...