Page MenuHomeFreeBSD
Differential D22017

Add NOEPOCHASSERT().
ClosedPublic
Actions

Authored by glebius on Oct 14 2019, 4:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 21, 3:42 AM
Unknown Object (File)
Fri, Oct 17, 7:10 PM
Unknown Object (File)
Fri, Oct 17, 7:10 PM
Unknown Object (File)
Fri, Oct 17, 7:10 PM
Unknown Object (File)
Fri, Oct 17, 7:10 PM
Unknown Object (File)
Fri, Oct 17, 10:15 AM
Unknown Object (File)
Tue, Oct 7, 6:16 AM
Unknown Object (File)
Tue, Oct 7, 5:34 AM
View All 88 Files
Subscribers
ae
imp

Details

Reviewers
jhb
• hselasky
Commits
rS353596: When assertion for a thread not being in an epoch fails also print all
Summary

Add a special assertion that would trigger if a thread
is in epoch. With EPOCH_TRACE present, it will also list the
epochs entered and entry points.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 27046
Build 25334: arc lint + arc unit

Event Timeline

glebius created this revision.Oct 14 2019, 4:19 AM
Herald added subscribers: ae, imp. · View Herald TranscriptOct 14 2019, 4:19 AM
Harbormaster completed remote builds in B27020: Diff 63242.Oct 14 2019, 4:20 AM
glebius added inline comments.Oct 14 2019, 4:22 AM
sys/net/if.c
3585 ↗(On Diff #63242)

This won't be part of commit. Added just to check functionality.

• hselasky accepted this revision.Oct 14 2019, 10:03 AM

Looks good.

This revision is now accepted and ready to land.Oct 14 2019, 10:03 AM
glebius updated this revision to Diff 63297.Oct 15 2019, 3:45 PM

Re-do the patch a bit. Instead of new macro, just add epoch_trace_list()
to the three critical places where we must not be in an epoch.

This revision now requires review to proceed.Oct 15 2019, 3:45 PM
Harbormaster completed remote builds in B27046: Diff 63297.Oct 15 2019, 3:45 PM
• hselasky added inline comments.Oct 15 2019, 3:59 PM
sys/kern/kern_synch.c
152

!= 0 instead of > 0 matches the KASSERT() below.

glebius added inline comments.Oct 15 2019, 4:19 PM
sys/kern/kern_synch.c
152

I don't agree. The value isn't boolean, it is an unsigned counter. Using > 0 is more correct.

• hselasky added inline comments.Oct 15 2019, 5:25 PM
sys/kern/kern_synch.c
152

I thought it was signed integer. If unsigned, then your check is OK.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 15 2019, 9:24 PM
Closed by commit rS353596: When assertion for a thread not being in an epoch fails also print all (authored by glebius). · Explain Why
This revision was automatically updated to reflect the committed changes.
glebius added a commit: rS353596: When assertion for a thread not being in an epoch fails also print all.

Revision Contents
Changeset List

PathSize
sys/
kern/
4 lines
4 lines
11 lines
4 lines
sys/
1 line

Diff 63297

View Options

sys/kern/kern_malloc.c

Loading...
View Options

sys/kern/kern_synch.c

Loading...
View Options

sys/kern/subr_epoch.c

Loading...
View Options

sys/kern/subr_trap.c

Loading...
View Options

sys/sys/epoch.h

Loading...