Differential D21926

RISC-V: Fix an alignment warning in libthr
ClosedPublic
Actions

Authored by mhorne on Oct 7 2019, 10:56 PM.

Details

Reviewers

markj
br
kp

Commits

rS354263: MFC r353334:
rS353334: RISC-V: Fix an alignment warning in libthr

Summary

Compiling with clang gives a loss-of-alignment error due the cast to
uint8_t *. Since the TLS is always tcb aligned and TP_OFFSET is defined
as sizeof(struct tcb) we can guarantee there is no misalignment. Silence
the error by moving the offset into the inline assembly.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 26925
Build 25229: arc lint + arc unit

Event Timeline

mhorne created this revision.Oct 7 2019, 10:56 PM

Harbormaster completed remote builds in B26917: Diff 63010.Oct 7 2019, 10:56 PM

Fix whitespace.

Harbormaster completed remote builds in B26925: Diff 63036.Oct 8 2019, 12:50 PM

br accepted this revision.Oct 8 2019, 1:01 PM

This revision is now accepted and ready to land.Oct 8 2019, 1:01 PM

Closed by commit rS353334: RISC-V: Fix an alignment warning in libthr (authored by mhorne). · Explain WhyOct 9 2019, 2:02 AM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rS353334: RISC-V: Fix an alignment warning in libthr.

Herald added a subscriber: imp. · View Herald TranscriptOct 9 2019, 2:02 AM

mhorne added a commit: rS354263: MFC r353334:.Nov 2 2019, 7:52 PM

Revision Contents
Changeset List

Path

Size

lib/

libthr/

arch/

riscv/

include/

pthread_md.h

8 lines

Diff 63036

View Options

lib/libthr/arch/riscv/include/pthread_md.h

	Show First 20 Lines • Show All 46 Lines • ▼ Show 20 Lines
	#include <sys/blockcount.h>			#include <sys/blockcount.h>
	#include <sys/condvar.h>			#include <sys/condvar.h>
	#include <sys/kdb.h>			#include <sys/kdb.h>
	#include <sys/kernel.h>			#include <sys/kernel.h>
	#include <sys/ktr.h>			#include <sys/ktr.h>
	#include <sys/lock.h>			#include <sys/lock.h>
	#include <sys/mutex.h>			#include <sys/mutex.h>
	#include <sys/proc.h>			#include <sys/proc.h>
				#include <sys/racct.h>
	#include <sys/resourcevar.h>			#include <sys/resourcevar.h>
	#include <sys/sched.h>			#include <sys/sched.h>
	#include <sys/sdt.h>			#include <sys/sdt.h>
	#include <sys/signalvar.h>			#include <sys/signalvar.h>
	#include <sys/sleepqueue.h>			#include <sys/sleepqueue.h>
	#include <sys/smp.h>			#include <sys/smp.h>
	#include <sys/sx.h>			#include <sys/sx.h>
	#include <sys/sysctl.h>			#include <sys/sysctl.h>
	▲ Show 20 Lines • Show All 384 Lines • ▼ Show 20 Lines
	/*			/*
	* Compute the amount of time during which the current			* Compute the amount of time during which the current
	* thread was running, and add that to its total so far.			* thread was running, and add that to its total so far.
	*/			*/
	new_switchtime = cpu_ticks();			new_switchtime = cpu_ticks();
	runtime = new_switchtime - PCPU_GET(switchtime);			runtime = new_switchtime - PCPU_GET(switchtime);
	td->td_runtime += runtime;			td->td_runtime += runtime;
	td->td_incruntime += runtime;			td->td_incruntime += runtime;
				#if defined(RACCT) && defined(RACCT_RT)
				if (RACCT_ENABLED())
				racct_rt_add_thread_runtime(td, runtime);
				#endif
	PCPU_SET(switchtime, new_switchtime);			PCPU_SET(switchtime, new_switchtime);
	td->td_generation++; /* bump preempt-detect counter */			td->td_generation++; /* bump preempt-detect counter */
	VM_CNT_INC(v_swtch);			VM_CNT_INC(v_swtch);
	PCPU_SET(switchticks, ticks);			PCPU_SET(switchticks, ticks);
	CTR4(KTR_PROC, "mi_switch: old thread %ld (td_sched %p, pid %ld, %s)",			CTR4(KTR_PROC, "mi_switch: old thread %ld (td_sched %p, pid %ld, %s)",
	td->td_tid, td_get_sched(td), td->td_proc->p_pid, td->td_name);			td->td_tid, td_get_sched(td), td->td_proc->p_pid, td->td_name);
	#ifdef KDTRACE_HOOKS			#ifdef KDTRACE_HOOKS
	if (SDT_PROBES_ENABLED() &&			if (SDT_PROBES_ENABLED() &&
	▲ Show 20 Lines • Show All 155 Lines • Show Last 20 Lines

RISC-V: Fix an alignment warning in libthrClosedPublicActions