ix: report isc_pause_frames during stat update
ClosedPublic
Actions

Authored by jacob.e.keller_intel.com on Oct 1 2019, 11:44 PM.

Details

Reviewers

Group Reviewers

Intel Networking
iflib

Commits

rS353657: ix: report isc_pause_frames during stat update

Summary

Notify the iflib stack of whether we received any pause frames during
the timer window. This allows the stack to avoid reporting a Tx hang due
to the device being paused.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 26822
Build 25156: arc lint + arc unit

Event Timeline

jacob.e.keller_intel.com created this revision.Oct 1 2019, 11:44 PM

Herald added a subscriber: ae. · View Herald TranscriptOct 1 2019, 11:44 PM

Harbormaster completed remote builds in B26822: Diff 62815.Oct 1 2019, 11:44 PM

erj added reviewers: Intel Networking, iflib.Oct 9 2019, 6:44 PM

erj set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptOct 9 2019, 6:44 PM

gallatin added a subscriber: gallatin.Oct 9 2019, 8:20 PM

gallatin added inline comments.

sys/dev/ixgbe/if_ix.c
1462	this comes from IXGBE_LXOFFTXC.. Isn't that a counter of the pause frames that we have sent? I would think you'd want to use IXGBE_LXOFFRXC, which I think counts the pause frames we've received..?