Page MenuHomeFreeBSD

e1000: correctly set isc_pause_frames only when XOFF increases
ClosedPublic

Authored by jacob.e.keller_intel.com on Oct 1 2019, 11:44 PM.
Tags
None
Referenced Files
F168788762: D21868.id62814.diff
Sun, Aug 30, 4:07 AM
Unknown Object (File)
Sat, Aug 29, 4:26 PM
Unknown Object (File)
Thu, Aug 27, 3:36 PM
Unknown Object (File)
Wed, Aug 26, 5:01 PM
Unknown Object (File)
Wed, Aug 26, 4:57 PM
Unknown Object (File)
Wed, Aug 26, 4:42 PM
Unknown Object (File)
Wed, Aug 26, 3:41 PM
Unknown Object (File)
Mon, Aug 24, 8:33 AM
Subscribers

Details

Summary

The e1000 driver sets the iflib shared context isc_pause_frames value to
the number of received xoff frames. This is done so that the iflib
watchdog timer won't trigger a Tx Hang due to pause frames.

Unfortunately, the function simply sets it to the value of the xoffrxc
counter. Once the device has received a single XOFF packet, the driver
always reports that we received pause frames. This will prevent the Tx
hang detection entirely from that point on.

Fix this by assigning isc_pause_frames to a non-zero value if we
received any XOFF packets in the last timer interval.

We could attempt to calculate the total number of received packets by
doing a subtraction, but the iflib stack only seems to check if
isc_pause_frames is non-zero.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26821
Build 25155: arc lint + arc unit