Page MenuHomeFreeBSD

e1000: correctly set isc_pause_frames only when XOFF increases
ClosedPublic

Authored by jacob.e.keller_intel.com on Oct 1 2019, 11:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 17, 1:13 AM
Unknown Object (File)
Sun, May 12, 6:46 PM
Unknown Object (File)
Fri, May 10, 4:40 PM
Unknown Object (File)
Sun, May 5, 7:18 PM
Unknown Object (File)
Apr 20 2024, 12:21 AM
Unknown Object (File)
Apr 8 2024, 11:42 AM
Unknown Object (File)
Apr 8 2024, 11:06 AM
Unknown Object (File)
Feb 19 2024, 5:55 PM
Subscribers

Details

Summary

The e1000 driver sets the iflib shared context isc_pause_frames value to
the number of received xoff frames. This is done so that the iflib
watchdog timer won't trigger a Tx Hang due to pause frames.

Unfortunately, the function simply sets it to the value of the xoffrxc
counter. Once the device has received a single XOFF packet, the driver
always reports that we received pause frames. This will prevent the Tx
hang detection entirely from that point on.

Fix this by assigning isc_pause_frames to a non-zero value if we
received any XOFF packets in the last timer interval.

We could attempt to calculate the total number of received packets by
doing a subtraction, but the iflib stack only seems to check if
isc_pause_frames is non-zero.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26821
Build 25155: arc lint + arc unit