Page MenuHomeFreeBSD

e1000: correctly set isc_pause_frames only when XOFF increases
ClosedPublic

Authored by jacob.e.keller_intel.com on Oct 1 2019, 11:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 6:47 AM
Unknown Object (File)
Dec 3 2024, 1:22 AM
Unknown Object (File)
Nov 20 2024, 5:54 PM
Unknown Object (File)
Oct 2 2024, 8:33 AM
Unknown Object (File)
Sep 23 2024, 8:09 AM
Unknown Object (File)
Sep 20 2024, 10:28 PM
Unknown Object (File)
Sep 16 2024, 4:02 PM
Unknown Object (File)
Sep 8 2024, 2:48 PM
Subscribers

Details

Summary

The e1000 driver sets the iflib shared context isc_pause_frames value to
the number of received xoff frames. This is done so that the iflib
watchdog timer won't trigger a Tx Hang due to pause frames.

Unfortunately, the function simply sets it to the value of the xoffrxc
counter. Once the device has received a single XOFF packet, the driver
always reports that we received pause frames. This will prevent the Tx
hang detection entirely from that point on.

Fix this by assigning isc_pause_frames to a non-zero value if we
received any XOFF packets in the last timer interval.

We could attempt to calculate the total number of received packets by
doing a subtraction, but the iflib stack only seems to check if
isc_pause_frames is non-zero.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable