Page MenuHomeFreeBSD
Differential D21862

Use OBJT_PHYS objects for linker files.
ClosedPublic
Actions

Authored by markj on Oct 1 2019, 7:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 27, 4:36 PM
Unknown Object (File)
Wed, Apr 22, 1:48 AM
Unknown Object (File)
Tue, Apr 21, 10:44 PM
Unknown Object (File)
Fri, Apr 17, 9:38 AM
Unknown Object (File)
Wed, Apr 15, 11:15 AM
Unknown Object (File)
Tue, Apr 14, 11:54 PM
Unknown Object (File)
Thu, Apr 9, 12:32 AM
Unknown Object (File)
Sun, Apr 5, 10:06 AM
View All 90 Files
Subscribers
imp

Details

Reviewers
alc
kib
Commits
rS353014: Use OBJT_PHYS VM objects for kernel modules.
Summary

... when SPARSE_MAPPING is defined.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26816
Build 25150: arc lint + arc unit

Event Timeline

markj created this revision.Oct 1 2019, 7:11 PM
Harbormaster completed remote builds in B26816: Diff 62804.Oct 1 2019, 7:11 PM
markj edited the summary of this revision. (Show Details)Oct 1 2019, 7:35 PM
markj added reviewers: alc, kib.
kib added a comment.Oct 1 2019, 9:21 PM

No objections, but why ? link_elf_obj also uses OBJT_DEFAULT.

markj added a comment.Oct 1 2019, 9:26 PM
In D21862#477610, @kib wrote:

No objections, but why ? link_elf_obj also uses OBJT_DEFAULT.

I don't see a reason to use OBJT_DEFAULT, and it carries more unnecessary overhead (pv entry allocation, for instance).

I will change link_elf_obj.c as well.

kib accepted this revision.Oct 2 2019, 1:40 PM
This revision is now accepted and ready to land.Oct 2 2019, 1:40 PM
alc accepted this revision.Oct 2 2019, 2:49 PM
Closed by commit rS353014: Use OBJT_PHYS VM objects for kernel modules. (authored by markj). · Explain WhyOct 2 2019, 4:34 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rS353014: Use OBJT_PHYS VM objects for kernel modules..
Herald added a subscriber: imp. · View Herald TranscriptOct 2 2019, 4:34 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
2 lines

Diff 62804

View Options

sys/kern/link_elf.c

Loading...