Use OBJT_PHYS objects for linker files.
ClosedPublic
Actions

Authored by markj on Oct 1 2019, 7:11 PM.

Details

Reviewers

alc
kib

Commits

rS353014: Use OBJT_PHYS VM objects for kernel modules.

Summary

... when SPARSE_MAPPING is defined.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Oct 1 2019, 7:11 PM

Harbormaster completed remote builds in B26816: Diff 62804.Oct 1 2019, 7:11 PM

markj edited the summary of this revision. (Show Details)Oct 1 2019, 7:35 PM

markj added reviewers: alc, kib.

No objections, but why ? link_elf_obj also uses OBJT_DEFAULT.

In D21862#477610, @kib wrote:

No objections, but why ? link_elf_obj also uses OBJT_DEFAULT.

I don't see a reason to use OBJT_DEFAULT, and it carries more unnecessary overhead (pv entry allocation, for instance).

I will change link_elf_obj.c as well.

kib accepted this revision.Oct 2 2019, 1:40 PM

This revision is now accepted and ready to land.Oct 2 2019, 1:40 PM

alc accepted this revision.Oct 2 2019, 2:49 PM

Closed by commit rS353014: Use OBJT_PHYS VM objects for kernel modules. (authored by markj). · Explain WhyOct 2 2019, 4:34 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS353014: Use OBJT_PHYS VM objects for kernel modules..

Herald added a subscriber: imp. · View Herald TranscriptOct 2 2019, 4:34 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

link_elf.c

2 lines

link_elf_obj.c

3 lines

Diff 62839

View Options

head/sys/kern/link_elf.c