Need to use ${${_${group}DIR_${file}}} for STAGE_DIR
ClosedPublic
Actions

Authored by sjg on Oct 1 2019, 7:06 PM.

Tags

None

Referenced Files

	F142050426: D21858.id62808.diff
	Thu, Jan 15, 11:45 AM

	F142050421: D21858.id62808.diff
	Thu, Jan 15, 11:45 AM

	F142048253: D21858.id62808.diff
	Thu, Jan 15, 10:51 AM

	Unknown Object (File)
	Sat, Jan 3, 2:40 AM

	Unknown Object (File)
	Dec 13 2025, 12:41 AM

	Unknown Object (File)
	Dec 2 2025, 3:52 PM

	Unknown Object (File)
	Dec 2 2025, 11:19 AM

	Unknown Object (File)
	Nov 23 2025, 5:27 PM

Subscribers

Details

Reviewers

bdrewery
stevek

Commits

rS353322: Need to use ${${_${group}DIR_${file}}} for STAGE_DIR
rS352942: Need to use ${${_${group}DIR_${file}}} for STAGE_DIR

Summary

STAGE_DIR.${${_${group}DIR_${file}}:C,[/*],_,g} was getting
${STAGE_OBJTOP}BINDIR rather than
${STAGE_OBJTOP}${BINDIR} when FILESDIR=BINDIR

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 26812
Build 25146: arc lint + arc unit

Event Timeline

sjg created this revision.Oct 1 2019, 7:06 PM

Herald added subscribers: emaste, imp, bdrewery. · View Herald TranscriptOct 1 2019, 7:06 PM

Harbormaster completed remote builds in B26812: Diff 62800.Oct 1 2019, 7:06 PM

sjg added reviewers: bdrewery, stevek.Oct 1 2019, 7:07 PM

stevek accepted this revision.Oct 1 2019, 7:22 PM

This revision is now accepted and ready to land.Oct 1 2019, 7:22 PM

Closed by commit rS352942: Need to use ${${_${group}DIR_${file}}} for STAGE_DIR (authored by sjg). · Explain WhyOct 1 2019, 8:32 PM

This revision was automatically updated to reflect the committed changes.

sjg added a commit: rS352942: Need to use ${${_${group}DIR_${file}}} for STAGE_DIR.

sjg added a commit: rS353322: Need to use ${${_${group}DIR_${file}}} for STAGE_DIR.Oct 8 2019, 8:14 PM

Revision Contents
Changeset List

Path

Size

share/

mk/

bsd.files.mk

2 lines

Diff 62800

View Options

Need to use ${${_${group}DIR_${file}}} for STAGE_DIRClosedPublicActions