Page MenuHomeFreeBSD
Differential D21789

snd_hda: Add Intel Cannon Lake support
ClosedPublic
Actions

Authored by nc on Sep 25 2019, 4:13 PM.
Tags
Referenced Files
Unknown Object (File)
Wed, Apr 17, 7:23 PM
Unknown Object (File)
Wed, Apr 10, 11:16 AM
Unknown Object (File)
Wed, Apr 10, 11:16 AM
Unknown Object (File)
Wed, Apr 10, 6:19 AM
Unknown Object (File)
Mon, Apr 8, 5:55 AM
Unknown Object (File)
Feb 29 2024, 7:28 AM
Unknown Object (File)
Jan 16 2024, 12:01 PM
Unknown Object (File)
Dec 20 2023, 8:26 AM
View All 26 Files
Subscribers
imp
jkim
ray
Contributor Reviews (src)

Details

Reviewers
mizhka
ray
imp
Commits
rS359114: MFC r352775-r352776
rS359113: MFC r352775-r352776
rS352775: snd_hda: Add Intel Cannon Lake support
Summary

The Intel Cannon Lake PCH is used on CPUs like Intel Whiskey Lake, and this patch allows HD Audio to work on these platforms.

Tested on the HP Spectre x360 13-p0043dx.

Inspired by Linux commit 2357f6f00098a437f9de084c3c34254d20dea789.

Bugzilla: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240574

Test Plan
  1. Get a system with Intel Cannon Lake PCH (e.g. I used a HP Spectre x360 13-p0043dx, but a X390/T490/X1C7 ThinkPad model should work as well, I can't test on a ThinkPad because I don't own one).
  2. Apply this patch to a source tree (CURRENT)
  3. Play something (e.g. YouTube video). Audio should work

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nc created this revision.Sep 25 2019, 4:13 PM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptSep 25 2019, 4:13 PM
nc added a reviewer: jkim.Sep 25 2019, 4:47 PM
nc added a subscriber: jkim.

Adding jkim@ as a review and subscriber.

nc edited the summary of this revision. (Show Details)Sep 25 2019, 4:54 PM
nc edited the test plan for this revision. (Show Details)
mizhka accepted this revision.Sep 25 2019, 5:15 PM
This revision is now accepted and ready to land.Sep 25 2019, 5:15 PM
nc removed a reviewer: jkim.Sep 25 2019, 5:19 PM

Thanks!

ray accepted this revision.Sep 25 2019, 7:01 PM
ray added a subscriber: ray.

Nice, that it works.

imp accepted this revision.Sep 25 2019, 8:41 PM

This looks good to my eye. Don't know if it will work...

Closed by commit rS352775: snd_hda: Add Intel Cannon Lake support (authored by gonzo). · Explain WhySep 26 2019, 9:02 PM
This revision was automatically updated to reflect the committed changes.
gonzo added a commit: rS352775: snd_hda: Add Intel Cannon Lake support.
gonzo added a commit: rS359113: MFC r352775-r352776.Mar 19 2020, 1:50 AM
gonzo added a commit: rS359114: MFC r352775-r352776.Mar 19 2020, 2:22 AM

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
sound/
pci/
hda/
1 line

Diff 62622

View Options

head/sys/dev/sound/pci/hda/hdac.c

Loading...