Page MenuHomeFreeBSD

snd_hda: Add Intel Cannon Lake support
ClosedPublic

Authored by neel_neelc.org on Sep 25 2019, 4:13 PM.

Details

Summary

The Intel Cannon Lake PCH is used on CPUs like Intel Whiskey Lake, and this patch allows HD Audio to work on these platforms.

Tested on the HP Spectre x360 13-p0043dx.

Inspired by Linux commit 2357f6f00098a437f9de084c3c34254d20dea789.

Bugzilla: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240574

Test Plan
  1. Get a system with Intel Cannon Lake PCH (e.g. I used a HP Spectre x360 13-p0043dx, but a X390/T490/X1C7 ThinkPad model should work as well, I can't test on a ThinkPad because I don't own one).
  2. Apply this patch to a source tree (CURRENT)
  3. Play something (e.g. YouTube video). Audio should work

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

neel_neelc.org created this revision.Sep 25 2019, 4:13 PM
neel_neelc.org added a subscriber: jkim.

Adding jkim@ as a review and subscriber.

neel_neelc.org edited the summary of this revision. (Show Details)Sep 25 2019, 4:54 PM
neel_neelc.org edited the test plan for this revision. (Show Details)
mizhka accepted this revision.Sep 25 2019, 5:15 PM
This revision is now accepted and ready to land.Sep 25 2019, 5:15 PM
ray accepted this revision.Sep 25 2019, 7:01 PM
ray added a subscriber: ray.

Nice, that it works.

imp accepted this revision.Sep 25 2019, 8:41 PM

This looks good to my eye. Don't know if it will work...

This revision was automatically updated to reflect the committed changes.