Scheduled to be released on 2019-09-26.
https://internals.rust-lang.org/t/1-38-0-pre-release-is-ready-for-testing/10992
https://github.com/rust-lang/rust/blob/stable/RELEASES.md#version-1380-2019-09-26
Details
Details
- Reviewers
jbeich pkubaj mikael val_packett.cool - Group Reviewers
rust O5: Ports Framework (Owns No Changed Paths) portmgr - Commits
- rP513013: lang/rust: Update to 1.38.0
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 26687 Build 25051: arc lint + arc unit
Event Timeline
Comment Actions
I forgot to upload them, it's ok now.
I screw up my testing on armv7 for the missing clear_cache symbol, compiler-rt is also required on armv7:
--- Makefile (revision 512718) +++ Makefile (working copy) @@ -18,6 +18,7 @@ ${_CARGO_BOOTSTRAP}${BOOTSTRAPS_SUFFIX}.tar.gz:cargo_bootstrap \ ${DISTFILES_${ARCH}} DISTFILES_armv6= compiler-rt-8.0.1.src.tar.xz:compiler_rt +DISTFILES_armv7= ${DISTFILES_armv6} DIST_SUBDIR?= rust EXTRACT_ONLY?= ${DISTFILES:N*\:*bootstrap:C/:.*//} @@ -106,7 +107,7 @@ ${WRKSRC}/build/cache/${_RUST_STD_BOOTSTRAP}.tar.gz ${LN} -sf ${DISTDIR}/${DIST_SUBDIR}/${_CARGO_BOOTSTRAP}${BOOTSTRAPS_SUFFIX}.tar.gz \ ${WRKSRC}/build/cache/${_CARGO_BOOTSTRAP}.tar.gz -.if ${ARCH} == armv6 +.if ${ARCH} == armv6 || ${ARCH} == armv7 ${LN} -sf ${WRKDIR}/compiler-rt-8.0.1.src ${WRKSRC}/src/llvm-project/compiler-rt .endif
gcc8 is probably not required anymore on ppc64. if I'm not mistaken, we switched to gcc9 some time ago, so the bootstrap are built with gcc9. I'll check tomorrow.
Comment Actions
- Unbreak devel/racer and update to 2.1.27
mail/thunderbird, www/firefox-esr, www/cliqz all fail to build with:
50:13.00 error[E0506]: cannot assign to `self.input.cached_token` because it is borrowed
50:13.00 --> /wrkdirs/usr/ports/www/cliqz/work/browser-f-1.28.2/mozilla-release/third_party/rust/cssparser/src/parser.rs:584:17
50:13.00 |
50:13.00 559 | pub fn next_including_whitespace_and_comments(&mut self) -> Result<&Token<'i>, BasicParseError<'i>> {
50:13.00 | - let's call the lifetime of this reference `'1`
50:13.00 ...
50:13.00 572 | Some(ref cached_token)
50:13.00 | ---------------- borrow of `self.input.cached_token` occurs here
50:13.00 ...
50:13.00 584 | self.input.cached_token = Some(CachedToken {
50:13.00 | ^^^^^^^^^^^^^^^^^^^^^^^ assignment to borrowed `self.input.cached_token` occurs here
50:13.00 ...
50:13.00 596 | Ok(token)
50:13.00 | --------- returning this value requires that `self.input.cached_token.0` is borrowed for `'1`
50:13.41 error: aborting due to previous errorhttps://people.freebsd.org/~tobik/logs/cliqz-1.28.2_1.log
https://people.freebsd.org/~tobik/logs/firefox-esr-68.1.0_3,1.log
https://people.freebsd.org/~tobik/logs/thunderbird-68.1.1.log
Comment Actions
- Backport [1] and unbreak cliqz, firefox-esr, thunderbird
[1] https://github.com/servo/rust-cssparser/commit/3c98d22c5de3b696bf1fde2b6c90069812312aa6
Comment Actions
my bootstrap still uses gcc8. We don't have binaries packages on 11.2 and gcc9 takes a lot of time to build on my powermac g5, so I'm still using gcc8. I'm migrating my jail to 12.0, we have binaries packages on this branch so it'll be easier for me to maintain rust on ppc64. If ppc64 users are complaining, they'll have to create the bootstrap themselves.
Comment Actions
Tip: if you bump PORTREVISION before testing consumers it'd save you time on rebuilds after landing.
Thanks. Looks OK to me.
| lang/rust/Makefile | ||
|---|---|---|
| 21 | Both lines may need update to 9.0.0 to match bundled LLVM. $ rustc -vV rustc 1.38.0 binary: rustc commit-hash: unknown commit-date: unknown host: x86_64-unknown-freebsd release: 1.38.0 LLVM version: 9.0 | |
Comment Actions
- Back to gcc8 on powerpc64
- Update compiler-rt to 9.0.0
- Bump consumers' PORTREVISION and Rust version in cargo.mk
Comment Actions
I've uploaded bootstrap for ppc64 / 12.0 / gcc9
http://mikael.urankar.free.fr/FreeBSD/rust/cargo-0.38.0-powerpc64-unknown-freebsd-elfv1.tar.gz
http://mikael.urankar.free.fr/FreeBSD/rust/rust-std-1.37.0-powerpc64-unknown-freebsd-elfv1.tar.gz
http://mikael.urankar.free.fr/FreeBSD/rust/rustc-1.37.0-powerpc64-unknown-freebsd-elfv1.tar.gz
Comment Actions
compiler-rt 9 breaks armv7:
running: "cc" "-O2" "-ffunction-sections" "-fdata-sections" "-fPIC" "-ffunction-sections" "-fdata-sections" "-fPIC" "-fno-builtin" "-fvisibility=hidden" "-ffreestanding" "-fomit-frame-pointer" "-DVISIBILITY_HIDDEN" "-o" "/usr/ports/lang/rust/work/rustc-1.38.0-src/build/armv7-unknown-freebsd/stage0-std/armv7-unknown-freebsd/release/build/compiler_builtins-7e603ab6ad926472/out/clear_cache.o" "-c" "/usr/ports/lang/rust/work/rustc-1.38.0-src/src/llvm-project/compiler-rt/lib/builtins/clear_cache.c" cargo:warning=In file included from /usr/ports/lang/rust/work/rustc-1.38.0-src/src/llvm-project/compiler-rt/lib/builtins/clear_cache.c:26: cargo:warning=/usr/include/machine/sysarch.h:97:22: error: unknown type name 'u_int' cargo:warning=int arm_sync_icache (u_int addr, int len); cargo:warning= ^ cargo:warning=1 error generated. exit code: 1
Comment Actions
There is something weird when fetching compiler-rt:
=> compiler-rt-9.0.0.src.tar.xz doesn't seem to exist in /mnt/usr/ports/distfiles/rust. => Attempting to fetch https://releases.llvm.org/9.0.0/compiler-rt-9.0.0.src.tar.xz fetch: 1993084: No such file or directory compiler-rt-9.0.0.src.tar.xz 1946 kB 22 MBps 00s => Attempting to fetch http://distcache.FreeBSD.org/ports-distfiles/rust/compiler-rt-9.0.0.src.tar.xz fetch: 1993084: No such file or directory fetch: http://distcache.FreeBSD.org/ports-distfiles/rust/compiler-rt-9.0.0.src.tar.xz: Not Found => Couldn't fetch it - please try to retrieve this => port manually into /mnt/usr/ports/distfiles/rust and try again.
compiler-rt is listed twice in the distinfo, I suppose the 'makesum' target is ran twice (for armv6 and armv7)
it builds fine on ppc64 elfv1, armv7 almost finished with compiler-rt 8 (I had to interrupt the build). I'm not sure I'll be able to test compiler-rt9 today.