Page MenuHomeFreeBSD
Differential D21735

www/gohugo: Update for D21730
ClosedPublic
Actions

Authored by dmgk on Sep 21 2019, 12:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 30, 10:56 AM
Unknown Object (File)
Sat, Mar 30, 10:56 AM
Unknown Object (File)
Sat, Mar 30, 10:56 AM
Unknown Object (File)
Sat, Mar 30, 10:56 AM
Unknown Object (File)
Sat, Mar 30, 10:42 AM
Unknown Object (File)
Feb 26 2024, 8:27 AM
Unknown Object (File)
Dec 22 2023, 12:13 AM
Unknown Object (File)
Dec 20 2023, 1:14 AM
View All 38 Files
Subscribers
mat

Details

Reviewers
tz
araujo
tobik
Commits
rP512675: Include bsd.port.pre.mk to get DISTINFO_FILE in scope for the shell command.
Summary

www/gohugo: Update for D21730

Include bsd.port.pre.mk to get DISTINFO_FILE in scope for the shell command.

Test Plan

poudriere testport: OK (120a)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 26647
Build 25021: arc lint + arc unit

Event Timeline

dmgk created this revision.Sep 21 2019, 12:22 PM
Herald added a subscriber: mat. · View Herald TranscriptSep 21 2019, 12:22 PM
Harbormaster completed remote builds in B26596: Diff 62374.Sep 21 2019, 12:22 PM
dmgk mentioned this in D21730: Mk/Uses/go.mk: Omit symbol table and debug information by default.Sep 21 2019, 12:28 PM
tobik accepted this revision.Sep 23 2019, 5:03 AM
tobik added inline comments.
www/gohugo/Makefile
129–131

I think this could use a short comment in the Makefile as to why it is after bsd.port.pre.mk.

I am not a big fan of grabbing TIMESTAMP from distinfo for this. I think the port should just set BuildDate to some static date that never changes. Recording the build date does not seem very important for the port and just makes it more complicated.

This revision is now accepted and ready to land.Sep 23 2019, 5:03 AM
dmgk updated this revision to Diff 62462.Sep 23 2019, 1:11 PM

Add Makefile comment on why bsd.port.pre.mk is needed.

This revision now requires review to proceed.Sep 23 2019, 1:11 PM
Harbormaster completed remote builds in B26646: Diff 62462.Sep 23 2019, 1:11 PM
dmgk marked an inline comment as done.Sep 23 2019, 1:11 PM
dmgk updated this revision to Diff 62464.Sep 23 2019, 1:13 PM

Shorten.

Harbormaster completed remote builds in B26647: Diff 62464.Sep 23 2019, 1:13 PM
tobik accepted this revision.Sep 23 2019, 4:01 PM
This revision is now accepted and ready to land.Sep 23 2019, 4:01 PM
araujo accepted this revision.Sep 23 2019, 7:58 PM
Closed by commit rP512675: Include bsd.port.pre.mk to get DISTINFO_FILE in scope for the shell command. (authored by dmgk). · Explain WhySep 23 2019, 8:42 PM
This revision was automatically updated to reflect the committed changes.
dmgk added a commit: rP512675: Include bsd.port.pre.mk to get DISTINFO_FILE in scope for the shell command..

Revision Contents
Changeset List

PathSize
www/
gohugo/
11 lines

Diff 62464

View Options

www/gohugo/Makefile

Loading...