Page MenuHomeFreeBSD
Differential D21531

Use zlib's uncompress function for simpler code.
ClosedPublic
Actions

Authored by ota_j.email.ne.jp on Sep 5 2019, 4:37 AM.
Tags
None
Referenced Files
F149607893: D21531.id.diff
Wed, Mar 25, 2:41 PM
Unknown Object (File)
Wed, Mar 11, 1:48 PM
Unknown Object (File)
Tue, Mar 10, 8:04 PM
Unknown Object (File)
Fri, Feb 27, 7:39 AM
Unknown Object (File)
Jan 31 2026, 6:22 PM
Unknown Object (File)
Jan 30 2026, 6:32 PM
Unknown Object (File)
Jan 26 2026, 4:25 PM
Unknown Object (File)
Jan 26 2026, 3:48 AM
View All Files
Subscribers
imp

Details

Reviewers
markj
delphij
Commits
rG852336780877: kern_ctf: Use zlib's uncompress function for simpler code.
rGcb17f4a6bdaf: kern_ctf: Use zlib's uncompress function for simpler code.
Summary

uncompress() does the same job.

Test Plan

DDB_CTF compile option is on by default.
But I'm not sure how to run this section of code.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26547
Build 24935: arc lint + arc unit

Event Timeline

ota_j.email.ne.jp created this revision.Sep 5 2019, 4:37 AM
Herald added a subscriber: imp. · View Herald TranscriptSep 5 2019, 4:37 AM
Harbormaster completed remote builds in B26285: Diff 61667.Sep 5 2019, 4:37 AM
markj accepted this revision.Sep 8 2019, 4:14 PM
markj added inline comments.
sys/kern/kern_ctf.c
247

FreeBSD style discourages CamelCase. The variable should be called something like destlen instead.

This revision is now accepted and ready to land.Sep 8 2019, 4:14 PM
ota_j.email.ne.jp updated this revision to Diff 62252.Sep 18 2019, 4:16 AM

destLen -> destlen.

This revision now requires review to proceed.Sep 18 2019, 4:16 AM
Harbormaster completed remote builds in B26547: Diff 62252.Sep 18 2019, 4:16 AM
delphij accepted this revision.Sep 18 2019, 4:38 AM

LGTM.

This revision is now accepted and ready to land.Sep 18 2019, 4:38 AM
markj accepted this revision.Sep 18 2019, 2:35 PM
Closed by commit rGcb17f4a6bdaf: kern_ctf: Use zlib's uncompress function for simpler code. (authored by ota_j.email.ne.jp, committed by delphij). · Explain WhySep 26 2021, 6:34 AM
This revision was automatically updated to reflect the committed changes.
delphij added a commit: rGcb17f4a6bdaf: kern_ctf: Use zlib's uncompress function for simpler code..
delphij added a commit: rG852336780877: kern_ctf: Use zlib's uncompress function for simpler code..Oct 10 2021, 5:10 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
24 lines

Diff 62252

View Options

sys/kern/kern_ctf.c

Loading...