Use zlib's uncompress function for simpler code.
ClosedPublic
Actions

Authored by ota_j.email.ne.jp on Sep 5 2019, 4:37 AM.

Details

Reviewers

markj
delphij

Commits

R10:852336780877: kern_ctf: Use zlib's uncompress function for simpler code.
R10:cb17f4a6bdaf: kern_ctf: Use zlib's uncompress function for simpler code.

Summary

uncompress() does the same job.

Test Plan

DDB_CTF compile option is on by default.
But I'm not sure how to run this section of code.

Diff Detail

Repository

R10 FreeBSD src repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ota_j.email.ne.jp created this revision.Sep 5 2019, 4:37 AM

Herald added a subscriber: imp. · View Herald TranscriptSep 5 2019, 4:37 AM

Harbormaster completed remote builds in B26285: Diff 61667.Sep 5 2019, 4:37 AM

markj accepted this revision.Sep 8 2019, 4:14 PM

markj added inline comments.

sys/kern/kern_ctf.c
247	FreeBSD style discourages CamelCase. The variable should be called something like `destlen` instead.

This revision is now accepted and ready to land.Sep 8 2019, 4:14 PM

destLen -> destlen.

This revision now requires review to proceed.Sep 18 2019, 4:16 AM

Harbormaster completed remote builds in B26547: Diff 62252.Sep 18 2019, 4:16 AM

LGTM.

This revision is now accepted and ready to land.Sep 18 2019, 4:38 AM

markj accepted this revision.Sep 18 2019, 2:35 PM

Closed by commit R10:cb17f4a6bdaf: kern_ctf: Use zlib's uncompress function for simpler code. (authored by ota_j.email.ne.jp, committed by delphij). · Explain WhySep 26 2021, 6:34 AM

This revision was automatically updated to reflect the committed changes.

delphij added a commit: R10:cb17f4a6bdaf: kern_ctf: Use zlib's uncompress function for simpler code..

delphij added a commit: R10:852336780877: kern_ctf: Use zlib's uncompress function for simpler code..Oct 10 2021, 5:10 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_ctf.c

24 lines

Diff 95747

View Options

Use zlib's uncompress function for simpler code.ClosedPublicActions