Page MenuHomeFreeBSD
Differential D21695

tftp: fix two minor Coverity CIDs
ClosedPublic
Actions

Authored by asomers on Sep 17 2019, 11:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 6, 6:24 AM
Unknown Object (File)
Wed, May 6, 5:27 AM
Unknown Object (File)
Wed, May 6, 12:00 AM
Unknown Object (File)
Thu, Apr 30, 7:04 PM
Unknown Object (File)
Thu, Apr 30, 5:24 PM
Unknown Object (File)
Apr 21 2026, 9:35 AM
Unknown Object (File)
Apr 19 2026, 2:25 PM
Unknown Object (File)
Apr 12 2026, 2:48 AM
View All Files
Subscribers
imp
koobs

Details

Reviewers
cem
Commits
rS354163: MFC r353068:
rS353068: tftp: fix two minor Coverity CIDs
Summary

tftp: fix two minor Coverity CIDs

CID 1394842: file descriptor leak in an error path
CID 1007603: single byte array overflow

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26540
Build 24934: arc lint + arc unit

Event Timeline

asomers created this revision.Sep 17 2019, 11:18 PM
Herald added a subscriber: imp. · View Herald TranscriptSep 17 2019, 11:18 PM
Harbormaster completed remote builds in B26540: Diff 62242.Sep 17 2019, 11:18 PM
koobs added a comment.Sep 18 2019, 3:43 AM

I'm not C savvy, so probably not appropriate for review (but thanks for adding me so I was aware of the change)

koobs removed a reviewer: koobs.Sep 18 2019, 3:43 AM
koobs added a subscriber: koobs.
This revision was not accepted when it landed; it landed in state Needs Review.Oct 3 2019, 8:22 PM
Closed by commit rS353068: tftp: fix two minor Coverity CIDs (authored by asomers). · Explain Why
This revision was automatically updated to reflect the committed changes.
asomers added a commit: rS353068: tftp: fix two minor Coverity CIDs.
asomers added a commit: rS354163: MFC r353068:.Oct 30 2019, 1:41 AM

Revision Contents
Changeset List

PathSize
usr.bin/
tftp/
3 lines

Diff 62242

View Options

usr.bin/tftp/main.c

Loading...