Fix an orphan bug and add tests for fork following.
ClosedPublic
Actions

Authored by jhb on Jun 14 2015, 5:20 AM.

Details

Reviewers

Commits

rS286158: Clear P_TRACED before reparenting a detached process back to its

Summary

Clear P_TRACED before reparenting a detached process back to its
original parent. Otherwise the debugee will be set as an orphan of
the debugger.

Add tests for tracing forks via PT_FOLLOW_FORK.

Test Plan

The ptrace__follow_fork_parent_detached_unrelated_debugger hangs without the change in sys_process.c. The debugger is hung in wait because when it calls the last wait, the orphan from the parent is still present, but after init harvests the parent it stays asleep with no orphans and no children.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

jhb updated this revision to Diff 6182.Jun 14 2015, 5:20 AM

jhb retitled this revision from to Fix an orphan bug and add tests for fork following..

jhb updated this object.

jhb edited the test plan for this revision. (Show Details)

jhb added a reviewer: kib.

Herald added subscribers: emaste, imp. · View Herald TranscriptJun 14 2015, 5:20 AM

kib accepted this revision.Jun 14 2015, 6:28 AM

kib edited edge metadata.

kib added inline comments.

sys/kern/sys_process.c
950	I think the comment which is equivalent to the explanation message of the revision, should be added there.

This revision is now accepted and ready to land.Jun 14 2015, 6:28 AM

emaste added inline comments.Jun 15 2015, 1:53 AM

sys/kern/sys_process.c
950	That sounds reasonable to me.

Rebase
Document why P_TRACED needs to be cleared.

This revision now requires review to proceed.Aug 1 2015, 5:47 AM

kib accepted this revision.Aug 1 2015, 6:05 AM

kib edited edge metadata.

This revision is now accepted and ready to land.Aug 1 2015, 6:05 AM

Closed by commit rS286158: Clear P_TRACED before reparenting a detached process back to its (authored by jhb). · Explain WhyAug 1 2015, 4:28 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

kern/

sys_process.c

2 lines

tests/

sys/

kern/

ptrace_test.c

581 lines

Diff 6182

View Options

sys/kern/sys_process.c

	Show First 20 Lines • Show All 220 Lines • ▼ Show 20 Lines
	gitref:ec3da16d8bc1[repository=src] (Sponsored by The FreeBSD Foundation)			gitref:ec3da16d8bc1[repository=src] (Sponsored by The FreeBSD Foundation)

	`openssl` has been upgraded to 3.0.15.			`openssl` has been upgraded to 3.0.15.
	gitref:cc43f991ab3e[repository=src]			gitref:cc43f991ab3e[repository=src]

	`unbound` has been upgraded to 1.22.0.			`unbound` has been upgraded to 1.22.0.
	gitref:0a096a7b3ae8[repository=src]			gitref:0a096a7b3ae8[repository=src]

				`libfido2` has been upgraded to 1.14.0.
				gitref:128bace5102e[repository=src] (Sponsored by The FreeBSD Foundation)

				`libcbor` has been upgraded to 0.11.0.
				gitref:128bace5102e[repository=src] (Sponsored by The FreeBSD Foundation)

				emasteUnsubmitted Not Done Inline Actions add these in alpha order probably emaste: add these in alpha order probably
	[[userland-deprecated-programs]]			[[userland-deprecated-programs]]
	=== Deprecated Applications			=== Deprecated Applications

	man:fdisk[8] has been deprecated in favor of man:gpart[8] for a long time but has not been removed, running this application will show a warning to migrate to man:gpart[8].			man:fdisk[8] has been deprecated in favor of man:gpart[8] for a long time but has not been removed, running this application will show a warning to migrate to man:gpart[8].
	gitref:3958be5c29da[repository=src] (Sponsored by The FreeBSD Foundation)			gitref:3958be5c29da[repository=src] (Sponsored by The FreeBSD Foundation)

	[[cloud]]			[[cloud]]
	== Cloud Support			== Cloud Support
	Show All 28 Lines
	gitref:38a1655adcb3[repository=src] (Sponsored by Intel Corporation)			gitref:38a1655adcb3[repository=src] (Sponsored by Intel Corporation)

	`ice_ddp` has been upgraded to 1.3.41.0.			`ice_ddp` has been upgraded to 1.3.41.0.
	gitref:a9d78bb714e3[repository=src] (Sponsored by Intel Corporation)			gitref:a9d78bb714e3[repository=src] (Sponsored by Intel Corporation)

	Meteor Lake support has been added to the man:ig4[4] driver.			Meteor Lake support has been added to the man:ig4[4] driver.
	gitref:56f0fc0011c2[repository=src]			gitref:56f0fc0011c2[repository=src]

				A new wireless driver is available: man:rtw89[4].
				bzUnsubmitted Not Done Inline Actions (not all chipsets may work yet) Given there was a specific complaint to re@ for the latest chipset for which this was the only report so far. bz: (not all chipsets may work yet) Given there was a specific complaint to re@ for the latest…
				jrmAuthorUnsubmitted Done Inline Actions Is it best to remove this note, then? jrm: Is it best to remove this note, then?
				bzUnsubmitted Not Done Inline Actions No, given the driver seems to work for at least two other chipsets for people. I only have one of four chipsets currently to test with myself (two more incoming). maybe (latest chipsets may not work yet) or maybe just leave it as-is and people can send bug reports (after all we are still fixing ath or rtwn chipsets after more than a decade). bz: No, given the driver seems to work for at least two other chipsets for people. I only have one…
				emasteUnsubmitted Not Done Inline Actions Should we add a brief note about which devices are supported by rtw89 (or maybe just something like "supporting a number of recent Realtek chipsets") emaste: Should we add a brief note about which devices are supported by rtw89 (or maybe just something…
				gitref:a2d1e07f6451[repository=src] (Sponsored by The FreeBSD Foundation)

				Support for Realtek 8156/8156B has been moved from from man:cdce[4] to man:ure[4].
				gitref:630077a84186[repository=src] (Sponsored by The FreeBSD Foundation)
				emasteUnsubmitted Not Done Inline Actions CC @lwhsu - maybe add something like "for improved performance and reliability"? emaste: CC @lwhsu - maybe add something like "for improved performance and reliability"?

	Support for ACPI GPIO _AEI objects has been added.			Support for ACPI GPIO _AEI objects has been added.
	gitref:1db6ffb2a482[repository=src] (Sponsored by Amazon)			gitref:1db6ffb2a482[repository=src] (Sponsored by Amazon)

	man:nvme[4] and man:nvmecontrol[8] have been enabled on all architectures.			man:nvme[4] and man:nvmecontrol[8] have been enabled on all architectures.
	gitref:24687a65dd7f[repository=src], gitref:aba2d7f89dcf[repository=src]			gitref:24687a65dd7f[repository=src], gitref:aba2d7f89dcf[repository=src]
	(Sponsored by Chelsio Communications and Netflix)			(Sponsored by Chelsio Communications and Netflix)

	[[drivers-removals]]			[[drivers-removals]]
	Show All 29 Lines
	gitref:4d3b05a8530e[repository=src] (Sponsored by Netflix)			gitref:4d3b05a8530e[repository=src] (Sponsored by Netflix)

	[[network]]			[[network]]
	== Networking			== Networking

	This section describes changes that affect networking in FreeBSD.			This section describes changes that affect networking in FreeBSD.

	[[network-protocols]]			[[network-protocols]]
	== Network Protocols			=== Network Protocols

	Lots of improvements to the network stack, including performance improvements and bug fixes for the man:sctp[4] stack.			Lots of improvements to the network stack, including performance improvements and bug fixes for the man:sctp[4] stack.

	[[network-general]]			[[network-general]]
	=== General Network			=== General Network

	AIM(Adaptive Interrupt Moderation) support has been added to the man:igc[4] driver.			AIM(Adaptive Interrupt Moderation) support has been added to the man:igc[4] driver.
	gitref:472a0ccf847a[repository=src] (Sponsored by Rubicon Communications, LLC ("Netgate") and BBOX.io)			gitref:472a0ccf847a[repository=src] (Sponsored by Rubicon Communications, LLC ("Netgate") and BBOX.io)

	These features has also been added to the man:lem[4] and man:em[4] drivers.			These features has also been added to the man:lem[4] and man:em[4] drivers.
	gitref:49f12d5b38f6[repository=src] (Sponsored by Rubicon Communications, LLC ("Netgate") and BBOX.io)			gitref:49f12d5b38f6[repository=src] (Sponsored by Rubicon Communications, LLC ("Netgate") and BBOX.io)

				[[wireless-networking]]
				=== Wireless Networking

				The LinuxKPI, particularly for 802.11, has been enhanced.
				This improves the stability of wireless drivers such as man:iwlwifi[4]. (Sponsored by The FreeBSD Foundation)

	[[hardware]]			[[hardware]]
	== Hardware Support			== Hardware Support

	This section covers general hardware support for physical machines, hypervisors, and virtualization environments, as well as hardware changes and updates that do not otherwise fit in other sections of this document.			This section covers general hardware support for physical machines, hypervisors, and virtualization environments, as well as hardware changes and updates that do not otherwise fit in other sections of this document.

	Please see link:https://www.freebsd.org/releases/{localRel}R/hardware[the list of hardware] supported by {releaseCurrent}, as well as link:https://www.freebsd.org/platforms/[the platforms page] for the complete list of supported CPU architectures.			Please see link:https://www.freebsd.org/releases/{localRel}R/hardware[the list of hardware] supported by {releaseCurrent}, as well as link:https://www.freebsd.org/platforms/[the platforms page] for the complete list of supported CPU architectures.

	[[processor]]			[[processor]]
	=== Processor Support			=== Processor Support

	Nominal support for POWER10 and POWER11 has been added.			Nominal support for POWER10 and POWER11 has been added.
	gitref:f9f006df1535[repository=src]			gitref:f9f006df1535[repository=src]

	[[hardware-virtualization]]			[[hardware-virtualization]]
	=== Virtualization Support			=== Virtualization Support

	The NVMM hypervisor is now detected.			The NVMM hypervisor is now detected.
	gitref:34f40baca641[repository=src]			gitref:34f40baca641[repository=src]

	The VNC server in man:bhyve[8] will now show the correct colors when using the package:www/novnc[] client.			The VNC server in man:bhyve[8] will now show the correct colors when using the package:www/novnc[] client.
	gitref:f9e09dc5b1d5[repository=src]			gitref:f9e09dc5b1d5[repository=src]

				[[multimedia]]
				== Multimedia

				Over 100 commits to improve the audio stack are included. (Sponsored by The FreeBSD Foundation)
				cpercivaUnsubmitted Done Inline Actions Can we point to anything specific which users might notice? This is a user-facing document so I prefer to talk about "added support for foo" rather than numbers of commits. cperciva: Can we point to anything specific which users might notice? This is a user-facing document so…


	[[ports]]			[[ports]]
	== Ports Collection and Package Infrastructure			== Ports Collection and Package Infrastructure

	This section covers changes to the FreeBSD Ports Collection, package infrastructure, and package maintenance and installation tools.			This section covers changes to the FreeBSD Ports Collection, package infrastructure, and package maintenance and installation tools.

	[[Installer]]			[[Installer]]
	=== Installer			=== Installer
	Show All 37 Lines