Page MenuHomeFreeBSD

pseudofs: make readdir work without a pid again
ClosedPublic

Authored by kevans on Sep 4 2019, 1:39 PM.
Tags
None
Referenced Files
F114700674: D21518.id.diff
Tue, Apr 15, 3:30 PM
F114699612: D21518.id61647.diff
Tue, Apr 15, 3:11 PM
F114690681: D21518.diff
Tue, Apr 15, 12:24 PM
Unknown Object (File)
Mon, Apr 14, 8:36 AM
Unknown Object (File)
Mon, Apr 14, 5:00 AM
Unknown Object (File)
Mon, Apr 14, 1:13 AM
Unknown Object (File)
Sun, Apr 13, 10:32 PM
Unknown Object (File)
Sat, Apr 12, 8:45 AM
Subscribers

Details

Summary

Specifically, the following was broken:

$ mount -t procfs procfs /proc
$ ls -l /proc

rS351741 reworked readdir slightly to avoid pfs_node/pidhash LOR, but inadvertently regressed pid == NO_PID; new pfs_lookup_proc() fails for the obvious reasons, and later pfs_visible_proc doesn't capture the pid == NO_PID -> return 1 aspect of pfs_visible. We can infact skip this whole block if we're operating on a NO_PID directory, as it's always visible.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable