Add a vop_stdioctl() that does the trivial algorithm for FIOSEEKDATA/FIOSEEKHOLE
ClosedPublic
Actions

Authored by rmacklem on Aug 17 2019, 3:17 AM.

Details

Reviewers

markj
kib

Commits

rS351201: Add a vop_stdioctl() that performs a trivial FIOSEEKDATA/FIOSEEKHOLE.

Summary

For file systems that do not implement holes, Linux provides the trivial implementation
for FIOSEEKDATA/FIOSEEKHOLE that returns the offset for FIOSEEKDATA and offset == file_size
for FIOSEEKHOLE.
Also, this seemed to be the preferred choice when discussed on freebsd-current@ w.r.t. what
to do when file systems don't implement VOP_IOCTL().

This patch implements this by adding a vop_stdioctl() that does it.

Test Plan

Tested using an NFS mount (which does not support VOP_IOCTL()) and a test program that does
lseek(SEEK_DATA) and lseek(SEEK_HOLE) for various offsets.
Since it is a VOP_IOCTL(), it follows the convention of returning ENOTTY for certain failures, even
though lseek() is not documented as returning that error (and ENOTTY is not listed as an errno for POSIX).

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 25939

Event Timeline

rmacklem created this revision.Aug 17 2019, 3:17 AM

Herald added a subscriber: imp. · View Herald TranscriptAug 17 2019, 3:17 AM

Harbormaster completed remote builds in B25930: Diff 60925.Aug 17 2019, 3:17 AM

kib added a subscriber: kib.Aug 17 2019, 10:57 AM

kib added inline comments.

kern/vfs_default.c
1155	I think you may check v_type before calling VOP_GETATTR()
1166	Add break; for consistency.

This version of the patch has the changes suggested by kib@ incorporated in it.
The only semantic change is that it now returns whatever error VOP_GETATTR()
returns if VOP_GETATTR() fails. This is consistent with the behaviour of vn_bmap_seekhole().

Harbormaster completed remote builds in B25939: Diff 60956.Aug 18 2019, 1:50 AM

kib accepted this revision.Aug 18 2019, 4:49 AM

This revision is now accepted and ready to land.Aug 18 2019, 4:49 AM

Closed by commit rS351201: Add a vop_stdioctl() that performs a trivial FIOSEEKDATA/FIOSEEKHOLE. (authored by rmacklem). · Explain WhyAug 19 2019, 12:29 AM

This revision was automatically updated to reflect the committed changes.

rmacklem added a commit: rS351201: Add a vop_stdioctl() that performs a trivial FIOSEEKDATA/FIOSEEKHOLE..