Differential D21108

Capsicumize readelf(1).
ClosedPublic
Actions

Authored by markj on Jul 29 2019, 7:43 PM.

Tags

None

Referenced Files

	F159337997: D21108.id60249.diff
	Sat, Jun 13, 12:37 AM

	Unknown Object (File)
	Fri, Jun 5, 4:21 PM

	Unknown Object (File)
	Wed, Jun 3, 12:02 PM

	Unknown Object (File)
	Tue, May 19, 8:24 PM

	Unknown Object (File)
	Apr 17 2026, 4:40 AM

	Unknown Object (File)
	Apr 8 2026, 7:20 PM

	Unknown Object (File)
	Apr 8 2026, 1:57 PM

	Unknown Object (File)
	Apr 6 2026, 10:40 AM

Subscribers

Details

Reviewers

oshogbo
emaste

Group Reviewers

Commits

rS350516: Capsicumize readelf(1).

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25575
Build 24180: arc lint + arc unit

Event Timeline

markj created this revision.Jul 29 2019, 7:43 PM

Herald added a subscriber: jonathan. · View Herald TranscriptJul 29 2019, 7:43 PM

Harbormaster completed remote builds in B25575: Diff 60249.Jul 29 2019, 7:43 PM

markj added a reviewer: capsicum.Jul 29 2019, 7:45 PM

markj added reviewers: oshogbo, emaste.

oshogbo accepted this revision.Jul 31 2019, 6:32 PM

oshogbo added inline comments.

contrib/elftoolchain/readelf/readelf.c
7673	In size we did fd, then filename, would it make sense to keep the same style?

This revision is now accepted and ready to land.Jul 31 2019, 6:32 PM

markj added inline comments.Jul 31 2019, 6:37 PM

contrib/elftoolchain/readelf/readelf.c
7673	I would prefer to pass it as an argument, but since these patches are not directly upstreamable (FreeBSD-specific), I prefer to minimize the size of the added diffs.

Closed by commit rS350516: Capsicumize readelf(1). (authored by markj). · Explain WhyAug 1 2019, 6:57 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS350516: Capsicumize readelf(1)..

Herald added a subscriber: imp. · View Herald TranscriptAug 1 2019, 6:57 PM

Revision Contents
Changeset List

Path

Size

contrib/

elftoolchain/

readelf/

39 lines

usr.bin/

readelf/

8 lines

Diff 60249

contrib/elftoolchain/readelf/readelf.c

Loading...

usr.bin/readelf/Makefile

Loading...