tidy up swap_pager_putpages
ClosedPublic
Actions

Authored by dougm on Jul 28 2019, 4:38 AM.

Details

Reviewers

alc
kib
markj

Commits

rS350392: In swap_pager_putpages, move the initialization of a free-blocks

Summary

(1) convert the panic() at the function's start into a KASSERT(), (2) convert sync into a bool-type variable async, (3) make the variable definitions style(9) compliant, and (4) move the calls to swp_pager_init_freerange() and swp_pager_freeswapspace() out from under the object lock.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dougm created this revision.Jul 28 2019, 4:38 AM

alc added inline comments.Jul 28 2019, 3:59 PM

swap_pager.c
1365 ↗	(On Diff #60208)	Isn't this assignment unnecessary?
1384 ↗	(On Diff #60208)	I think it's within the scope of this patch to fix the style issue here: Add spaces around the '+'.
1414 ↗	(On Diff #60208)	Add spaces around the '+'.

alc added inline comments.Jul 28 2019, 4:04 PM

swap_pager.c
1355 ↗	(On Diff #60208)	I think that this one line no longer applies.
1364 ↗	(On Diff #60208)	I would delete this blank line because the above block comment describes the below initialization to 'async'.

Apply reviewer suggestions. Make another style(9) fix.

alc added inline comments.Jul 28 2019, 4:47 PM

swap_pager.c
1335 ↗	(On Diff #60211)	Please fix the "whos".
1355–1356 ↗	(On Diff #60211)	Please capitalize and punctuate these sentences.
1387 ↗	(On Diff #60211)	Shouldn't this be a period instead of a comma?