Differential D21093

tidy up swap_pager_putpages
ClosedPublic
Actions

Authored by dougm on Jul 28 2019, 4:38 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jan 7, 8:43 PM

	Unknown Object (File)
	Sun, Dec 22, 8:43 AM

	Unknown Object (File)
	Oct 26 2024, 2:54 AM

	Unknown Object (File)
	Oct 17 2024, 4:07 AM

	Unknown Object (File)
	Oct 10 2024, 12:56 AM

	Unknown Object (File)
	Sep 12 2024, 10:30 PM

	Unknown Object (File)
	Sep 7 2024, 10:08 PM

	Unknown Object (File)
	Aug 31 2024, 3:02 AM

View All 67 Files

Subscribers

Details

Reviewers

alc
kib
markj

Commits

rS350392: In swap_pager_putpages, move the initialization of a free-blocks

Summary

(1) convert the panic() at the function's start into a KASSERT(), (2) convert sync into a bool-type variable async, (3) make the variable definitions style(9) compliant, and (4) move the calls to swp_pager_init_freerange() and swp_pager_freeswapspace() out from under the object lock.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dougm created this revision.Jul 28 2019, 4:38 AM

alc added inline comments.Jul 28 2019, 3:59 PM

swap_pager.c
1365–1366	Isn't this assignment unnecessary?
1381	I think it's within the scope of this patch to fix the style issue here: Add spaces around the '+'.
1410–1411	Add spaces around the '+'.

alc added inline comments.Jul 28 2019, 4:04 PM

swap_pager.c
1354–1355	I think that this one line no longer applies.
1365	I would delete this blank line because the above block comment describes the below initialization to 'async'.

Apply reviewer suggestions. Make another style(9) fix.

alc added inline comments.Jul 28 2019, 4:47 PM

swap_pager.c
1335	Please fix the "whos".
1354–1355	Please capitalize and punctuate these sentences.
1386	Shouldn't this be a period instead of a comma?

Tidy up comments.

I think that this is a good change and ready to commit. Give Kostik and Mark a chance to comment.

This revision is now accepted and ready to land.Jul 28 2019, 5:07 PM

markj accepted this revision.Jul 28 2019, 6:34 PM

kib accepted this revision.Jul 28 2019, 7:05 PM

Closed by commit rS350392: In swap_pager_putpages, move the initialization of a free-blocks (authored by dougm). · Explain WhyJul 28 2019, 7:32 PM

This revision was automatically updated to reflect the committed changes.

dougm added a commit: rS350392: In swap_pager_putpages, move the initialization of a free-blocks.

Herald added a subscriber: imp. · View Herald TranscriptJul 28 2019, 7:32 PM

Revision Contents
Changeset List

Path

Size

55 lines

Diff 60213

swap_pager.c

Loading...