Page MenuHomeFreeBSD
Differential D21086

pf: Remove partial RFC2675 support
ClosedPublic
Actions

Authored by kp on Jul 27 2019, 1:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 20, 3:25 PM
Unknown Object (File)
Fri, Apr 19, 2:26 PM
Unknown Object (File)
Fri, Apr 19, 9:09 AM
Unknown Object (File)
Tue, Apr 16, 10:18 PM
Unknown Object (File)
Sat, Apr 6, 5:02 PM
Unknown Object (File)
Jan 1 2024, 7:19 AM
Unknown Object (File)
Nov 14 2023, 6:05 PM
Unknown Object (File)
Nov 9 2023, 7:17 PM
View All 28 Files
Subscribers
ae
farrokhi
imp

Details

Reviewers
thj
Group Reviewers
network
Commits
rS350414: pf: Remove partial RFC2675 support
Summary

Remove our (very partial) support for RFC2675 Jumbograms. They're not
used, not actually supported and not a good idea.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25537
Build 24152: arc lint + arc unit

Event Timeline

kp created this revision.Jul 27 2019, 1:32 PM
Herald added a subscriber: farrokhi. · View Herald TranscriptJul 27 2019, 1:32 PM
Harbormaster completed remote builds in B25537: Diff 60194.Jul 27 2019, 1:32 PM
kp added a reviewer: thj.Jul 27 2019, 1:32 PM
kp set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptJul 27 2019, 1:32 PM
thj added inline comments.Jul 28 2019, 4:49 PM
sys/netpfil/pf/pf_norm.c
1237

if we don't support jumbo, shouldn't we just drop any packet with the jumbo option? i.e.

case IP6OPT_JUMP: goto drop

and then we can remove all this handling?

kp updated this revision to Diff 60218.Jul 28 2019, 7:44 PM

Remove more bits, as suggested by thj

Harbormaster completed remote builds in B25553: Diff 60218.Jul 28 2019, 7:44 PM
kp marked an inline comment as done.Jul 28 2019, 7:45 PM
thj accepted this revision.Jul 28 2019, 8:01 PM
This revision is now accepted and ready to land.Jul 28 2019, 8:01 PM
ae added a subscriber: ae.Jul 29 2019, 10:20 AM

Does this mean that you concluded in the IETF mailing list to drop this support?

Closed by commit rS350414: pf: Remove partial RFC2675 support (authored by kp). · Explain WhyJul 29 2019, 1:21 PM
This revision was automatically updated to reflect the committed changes.
kp added a commit: rS350414: pf: Remove partial RFC2675 support.
kp added a comment.Jul 29 2019, 1:55 PM
In D21086#457948, @ae wrote:

Does this mean that you concluded in the IETF mailing list to drop this support?

I listened in to the relevant session in the IETF meeting, and while I don't know if there was a firm conclusion even those opposing moving RFC2675 to historic status were very clear that its implementation is optional, and it's entirely okay to not support it.

Revision Contents
Changeset List

PathSize
sys/
netpfil/
pf/
4 lines
16 lines

Diff 60194

View Options

sys/netpfil/pf/pf.c

Loading...
View Options

sys/netpfil/pf/pf_norm.c

Loading...