Details

For rockchip there is a clock exposed (via the clock-output-names property) but you don't register it and you try to get it in the emmc-phy review (D20840).

This means that the sdhci driver should first expose the clock, wait for the phy driver with the help of newpass to be attached and then resume the work on sd/emmc detection.
I also think that you should subclass the driver since this will add a lot of rockchip related code.

Updated accordingly.

Harbormaster completed remote builds in B25363: Diff 59802.Jul 16 2019, 12:16 PM

manu added inline comments.Jul 16 2019, 12:44 PM

sys/dev/sdhci/sdhci_fdt.c
161 ↗	(On Diff #59802)	You should validate that this was the emmcclock that was requested based on the cells content and return ENXIO if it wasn't
481 ↗	(On Diff #59802)	phy_init(sc->phy);

Updated accordingly.

Harbormaster completed remote builds in B25364: Diff 59804.Jul 16 2019, 2:29 PM

Looks like phydev_if.h is not needed, and no other functional changes.

Harbormaster completed remote builds in B25390: Diff 59861.Jul 18 2019, 3:01 AM

manu requested changes to this revision.Jul 18 2019, 8:39 AM

manu added inline comments.

sys/dev/sdhci/sdhci_fdt.c
492 ↗	(On Diff #59861)	I would prefer this block to be in a deticated rockchip function.
161 ↗	(On Diff #59802)	You still don't validate the clock id based on cells[0] content.

This revision now requires changes to proceed.Jul 18 2019, 8:39 AM

Added ncells check in rk3399_ofw_map() function according to comment.
Moved rk3399 sdhci init related codes into sdhci_init_rk3399() function so that it looks more clean.

Harbormaster completed remote builds in B25394: Diff 59873.Jul 18 2019, 10:00 AM

manu accepted this revision.Jul 19 2019, 5:59 PM

This revision is now accepted and ready to land.Jul 19 2019, 5:59 PM

Closed by commit rS350162: Add emmc support for Rockchip RK3399 SoC. (authored by ganbold). · Explain WhyJul 20 2019, 2:53 AM

This revision was automatically updated to reflect the committed changes.

ganbold added a commit: rS350162: Add emmc support for Rockchip RK3399 SoC..