ata_xpt: Use the correct union member when accessing valid
ClosedPublic
Actions

Authored by brooks on Jul 19 2019, 10:29 PM.

Details

Reviewers

scottl
imp

Commits

rS350545: MFC r350228:
rS350543: MFC r350228:
rS350228: ata_xpt: Use the correct union member when accessing valid.

Summary

In principle this should not matter as it's a union and they point to
the same memory location but based on the code above we should be
accessing .sata and not .ata

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25432
Build 24060: arc lint + arc unit

Event Timeline

brooks created this revision.Jul 19 2019, 10:29 PM

Harbormaster completed remote builds in B25432: Diff 59947.Jul 19 2019, 10:29 PM

I found this in our CheriBSD diffs. I'm not sure how @arichardson ran into it.

I'm not sure why I made that change. I just remember that we had some compiler bugs in that function that went away when I added a printf. I think this was just one of the suspicious things that I saw so I made the change hoping that it would fix the miscompilation.

scottl accepted this revision.Jul 20 2019, 6:07 AM

This revision is now accepted and ready to land.Jul 20 2019, 6:07 AM

imp accepted this revision.Jul 20 2019, 6:11 AM

Closed by commit rS350228: ata_xpt: Use the correct union member when accessing valid. (authored by brooks). · Explain WhyJul 22 2019, 9:08 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rS350228: ata_xpt: Use the correct union member when accessing valid..

brooks added a commit: rS350543: MFC r350228:.Aug 2 2019, 8:31 PM

brooks added a commit: rS350545: MFC r350228:.Aug 2 2019, 10:34 PM