Page MenuHomeFreeBSD

ata_xpt: Use the correct union member when accessing valid
ClosedPublic

Authored by brooks on Jul 19 2019, 10:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 10:09 PM
Unknown Object (File)
Fri, Dec 20, 6:37 PM
Unknown Object (File)
Thu, Dec 12, 8:02 PM
Unknown Object (File)
Mon, Dec 9, 11:07 AM
Unknown Object (File)
Fri, Dec 6, 2:44 AM
Unknown Object (File)
Oct 31 2024, 5:01 AM
Unknown Object (File)
Oct 19 2024, 5:10 AM
Unknown Object (File)
Oct 4 2024, 11:54 AM
Subscribers

Details

Summary

In principle this should not matter as it's a union and they point to
the same memory location but based on the code above we should be
accessing .sata and not .ata

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25432
Build 24060: arc lint + arc unit

Event Timeline

I found this in our CheriBSD diffs. I'm not sure how @arichardson ran into it.

I'm not sure why I made that change. I just remember that we had some compiler bugs in that function that went away when I added a printf. I think this was just one of the suspicious things that I saw so I made the change hoping that it would fix the miscompilation.

This revision is now accepted and ready to land.Jul 20 2019, 6:07 AM