Differential D20949

Two issues with casueword(9) update.
ClosedPublic
Actions

Authored by kib on Jul 14 2019, 6:21 PM.

Tags

None

Referenced Files

	F170857070: D20949.id59752.diff
	Mon, Sep 7, 2:05 AM

	Unknown Object (File)
	Fri, Sep 4, 5:11 PM

	Unknown Object (File)
	Fri, Sep 4, 11:08 AM

	Unknown Object (File)
	Fri, Sep 4, 6:52 AM

	Unknown Object (File)
	Fri, Sep 4, 4:28 AM

	Unknown Object (File)
	Thu, Sep 3, 5:08 PM

	Unknown Object (File)
	Thu, Sep 3, 12:00 PM

	Unknown Object (File)
	Thu, Sep 3, 11:31 AM

View All Files

Subscribers

imp

pho

Details

Reviewers

markj

Commits

rS349995: In do_lock_pi(), do not return prematurely.
rS349994: Correctly check for casueword(9) success in do_set_ceiling().

Summary

In do_lock_pi(), properly clean up resources on umxq_check_susp() indicating block.
In do_set_ceiling(), properly verify that the operation succeed, it is not enough to compare old and new.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 25339

Event Timeline

kib created this revision.Jul 14 2019, 6:21 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 14 2019, 6:21 PM

Harbormaster completed remote builds in B25339: Diff 59742.Jul 14 2019, 6:21 PM

markj accepted this revision.Jul 14 2019, 6:39 PM

This revision is now accepted and ready to land.Jul 14 2019, 6:39 PM

I tested D20949.59742.diff with all of the threaded tests I have, on i386. No problems seen.

Closed by commit rS349994: Correctly check for casueword(9) success in do_set_ceiling(). (authored by kib). · Explain WhyJul 15 2019, 8:38 AM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rS349994: Correctly check for casueword(9) success in do_set_ceiling()..

kib added a commit: rS349995: In do_lock_pi(), do not return prematurely..

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_umtx.c

5 lines

Diff 59742

View Options

Two issues with casueword(9) update.ClosedPublicActions