Page MenuHomeFreeBSD

Fix gcc build for cxgbe(4)
ClosedPublic

Authored by lwhsu on Jul 8 2019, 11:57 AM.
Tags
None
Referenced Files
F136989203: D20879.id.diff
Thu, Nov 20, 10:31 PM
F136988923: D20879.id59531.diff
Thu, Nov 20, 10:30 PM
F136987936: D20879.id59548.diff
Thu, Nov 20, 10:26 PM
F136986547: D20879.diff
Thu, Nov 20, 10:20 PM
Unknown Object (File)
Sat, Nov 8, 3:50 AM
Unknown Object (File)
Wed, Nov 5, 6:35 AM
Unknown Object (File)
Wed, Nov 5, 2:25 AM
Unknown Object (File)
Tue, Nov 4, 4:59 PM
Subscribers

Details

Summary

On https://ci.freebsd.org/job/FreeBSD-head-amd64-gcc/10647/console:

--- all_subdir_cxgbe ---
In file included from /usr/home/lwhsu/freebsd-src/sys/dev/cxgbe/tom/t4_cpl_io.c:30:0:
/usr/home/lwhsu/freebsd-src/sys/dev/cxgbe/tom/t4_cpl_io.c: In function 'alloc_aiotx_mbuf':
/usr/home/lwhsu/freebsd-src/sys/dev/cxgbe/tom/t4_cpl_io.c:1988:33: error: suggest parentheses around '+' in operand of '&' [-Werror=parentheses]
   KASSERT(mlen == len || (start + mlen & PAGE_MASK) == 0,
                           ~~~~~~^~~
/usr/home/lwhsu/freebsd-src/sys/sys/cdefs.h:455:51: note: in definition of macro '__predict_false'
 #define __predict_false(exp)    __builtin_expect((exp), 0)
                                                   ^~~
/usr/home/lwhsu/freebsd-src/sys/dev/cxgbe/tom/t4_cpl_io.c:1988:3: note: in expansion of macro 'KASSERT'
   KASSERT(mlen == len || (start + mlen & PAGE_MASK) == 0,
   ^~~~~~~
Test Plan

make -DNO_CLEAN CROSS_TOOLCHAIN=amd64-gcc buildworld buildkernel

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25242
Build 23911: arc lint + arc unit