Ignore kern.vt.splash_cpu on bhyve
ClosedPublic
Actions

Authored by vangyzen on Jul 7 2019, 10:36 PM.

Details

Reviewers

cem
dumbbell

Commits

rS350056: MFC r349834
rS350050: MFC r349834
rS349834: Ignore kern.vt.splash_cpu without graphics

Summary

If kern.vt.splash_cpu is set on a machine without graphics, such as bhyve
in some configurations, do not panic. Simply ignore splash_cpu and keep
booting.

Test Plan

OK set kern.vt.splash_cpu="1"
OK boot
...
VT: init without driver.
...
vt_init_logos: vd 0xffffffff81ae6c40 not initialized

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25239
Build 23908: arc lint + arc unit

Event Timeline

vangyzen created this revision.Jul 7 2019, 10:36 PM

Herald added subscribers: dab, badger, imp. · View Herald TranscriptJul 7 2019, 10:36 PM

Harbormaster completed remote builds in B25239: Diff 59525.Jul 7 2019, 10:36 PM

vangyzen added a reviewer: dumbbell.Jul 7 2019, 10:37 PM

vangyzen added inline comments.

sys/dev/vt/vt_cpulogos.c
233	Is the `printf` valuable? I would be happy to remove it.

cem accepted this revision.Jul 8 2019, 5:57 AM

This revision is now accepted and ready to land.Jul 8 2019, 5:57 AM

I would change the commit summary/title, though. Really we're just disabling a feature when it is unsupported by some particular configuration; it's not bhyve-specific.

dumbbell accepted this revision.Jul 8 2019, 6:02 AM

dumbbell added inline comments.