Page MenuHomeFreeBSD
Differential D20846

boolean_t to bool in wire/unwire fucntions
ClosedPublic
Actions

Authored by dougm on Jul 3 2019, 10:28 PM.
Tags
None
Referenced Files
F156716315: D20846.id59374.diff
Fri, May 15, 9:02 PM
F156716249: D20846.id59407.diff
Fri, May 15, 9:02 PM
F156716237: D20846.id59406.diff
Fri, May 15, 9:02 PM
F156715815: D20846.diff
Fri, May 15, 8:58 PM
Unknown Object (File)
Mon, May 11, 1:24 AM
Unknown Object (File)
Tue, May 5, 4:47 AM
Unknown Object (File)
Mon, May 4, 11:36 AM
Unknown Object (File)
Sun, May 3, 11:43 PM
View All Files
Subscribers
imp

Details

Reviewers
alc
markj
Commits
rS349743: Change boolean_t variables in vm_map_unwire and vm_map_wire_locked to
Summary

Change boolean_t variables in vm_map_unwire and vm_map_wire_locked to bool. Drop result variable. Add holes_ok bool to replace repeated masking of flags parameter.

This is part of a larger patch that I've been ask to break up into smaller pieces.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dougm created this revision.Jul 3 2019, 10:28 PM
dougm edited the summary of this revision. (Show Details)Jul 4 2019, 6:48 PM
dougm added a reviewer: markj.
markj added a comment.Jul 4 2019, 7:00 PM

Thanks, I was also going to suggest extracting this patch into a separate commit.

sys/vm/vm_map.c
3217 ↗(On Diff #59374)

Shouldn't it be KASSERT(false)?

dougm updated this revision to Diff 59406.Jul 4 2019, 7:06 PM

Resolve merge conflicts. Don't confuse true with false.

markj accepted this revision.Jul 4 2019, 7:09 PM
This revision is now accepted and ready to land.Jul 4 2019, 7:09 PM
Closed by commit rS349743: Change boolean_t variables in vm_map_unwire and vm_map_wire_locked to (authored by dougm). · Explain WhyJul 4 2019, 7:12 PM
This revision was automatically updated to reflect the committed changes.
dougm added a commit: rS349743: Change boolean_t variables in vm_map_unwire and vm_map_wire_locked to.
Herald added a subscriber: imp. · View Herald TranscriptJul 4 2019, 7:12 PM

Revision Contents
Changeset List

PathSize
71 lines

Diff 59406

View Options

vm_map.c

Loading...