Differential D20852

elfcopy: Clear errors after fetching the shstrtab index.
ClosedPublic
Actions

Authored by markj on Jul 4 2019, 2:55 PM.

Details

Reviewers

Commits

rS349730: elfcopy: Clear errors after fetching the shstrtab index.

Summary

Otherwise a future call to elf_errno() will return a non-zero value.
update_shdr(), for example, treats any errors associated with the ELF
descriptor as fatal. Clear the error per the first example in
elf_errmsg.3.

Convert to elf_getshdrstrndx() while here since elf_getshstrndx() is
apparently deprecated.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Jul 4 2019, 2:55 PM

Harbormaster completed remote builds in B25198: Diff 59393.Jul 4 2019, 2:55 PM

markj added a reviewer: emaste.Jul 4 2019, 2:56 PM

markj added a subscriber: royger.

emaste accepted this revision.Jul 4 2019, 2:59 PM

This revision is now accepted and ready to land.Jul 4 2019, 2:59 PM

Closed by commit rS349730: elfcopy: Clear errors after fetching the shstrtab index. (authored by markj). · Explain WhyJul 4 2019, 3:07 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS349730: elfcopy: Clear errors after fetching the shstrtab index..

Herald added a subscriber: imp. · View Herald TranscriptJul 4 2019, 3:07 PM

dim mentioned this in rS367466: Sync up elftoolchain with head, except for the capsicum-related commits,.Nov 7 2020, 11:58 PM

Revision Contents
Changeset List

Path

Size

head/

contrib/

elftoolchain/

elfcopy/

sections.c

4 lines

Diff 59395

View Options

head/contrib/elftoolchain/elfcopy/sections.c

elfcopy: Clear errors after fetching the shstrtab index.ClosedPublicActions