Differential D20798

cxgbe/t4_tom: the aio tx job queue must be empty by the time the toepcb is freed.
ClosedPublic
Actions

Authored by np on Jun 28 2019, 7:13 PM.

Details

Reviewers

Commits

rS349795: MFC r349242, r349501, r349514, and r349517.
rS349514: cxgbe/t4_tom: the AIO tx job queue must be empty by the time the driver

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25113
Build 23812: arc lint + arc unit

Event Timeline

np created this revision.Jun 28 2019, 7:13 PM

Herald added subscribers: ae, imp. · View Herald TranscriptJun 28 2019, 7:13 PM

Harbormaster completed remote builds in B25113: Diff 59167.Jun 28 2019, 7:13 PM

jhb added inline comments.Jun 28 2019, 7:15 PM

sys/dev/cxgbe/tom/t4_tom.c
297	Now that the jobq holds a reference on the socket (in effect), I think that hold on the socket prevents release_offload_resources() from being called? If soref() alone doesn't prevent that, then I'm less certain this will actually be true.

On further thought, I think this is ok. If the jobq isn't empty, then at least one job exists, and that job would hold a reference on the struct file and thus keep the socket "open".

This revision is now accepted and ready to land.Jun 28 2019, 7:19 PM

Closed by commit rS349514: cxgbe/t4_tom: the AIO tx job queue must be empty by the time the driver (authored by np). · Explain WhyJun 28 2019, 7:28 PM

This revision was automatically updated to reflect the committed changes.

np added a commit: rS349514: cxgbe/t4_tom: the AIO tx job queue must be empty by the time the driver.

np added a commit: rS349795: MFC r349242, r349501, r349514, and r349517..Jul 7 2019, 12:30 AM