Differential D20760

libelftc: Micro-optimize strtab insertion.
ClosedPublic
Actions

Authored by markj on Jun 25 2019, 4:24 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Mar 18, 5:07 AM

	Unknown Object (File)
	Tue, Mar 17, 11:03 PM

	Unknown Object (File)
	Sat, Mar 7, 11:53 AM

	Unknown Object (File)
	Wed, Mar 4, 8:03 PM

	Unknown Object (File)
	Mon, Mar 2, 1:16 PM

	Unknown Object (File)
	Sun, Mar 1, 11:48 AM

	Unknown Object (File)
	Jan 18 2026, 8:09 AM

	Unknown Object (File)
	Dec 17 2025, 9:53 AM

View All Files

Subscribers

imp

Details

Reviewers

emaste
jkoshy_users.sourceforge.net
kaiw

Commits

rS349420: libelftc: Micro-optimize string table insertion.

Summary

We already know the length of the string, so use memcpy() instead of
strcpy() to add it to the string table image.

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 25040
Build 23754: arc lint + arc unit

Event Timeline

markj created this revision.Jun 25 2019, 4:24 PM

Harbormaster completed remote builds in B25040: Diff 59014.Jun 25 2019, 4:24 PM

markj added reviewers: emaste, jkoshy_users.sourceforge.net, kaiw.Jun 25 2019, 4:25 PM

emaste accepted this revision.Jun 25 2019, 7:59 PM

This revision is now accepted and ready to land.Jun 25 2019, 7:59 PM

Closed by commit rS349420: libelftc: Micro-optimize string table insertion. (authored by markj). · Explain WhyJun 26 2019, 4:30 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS349420: libelftc: Micro-optimize string table insertion..

Herald added a subscriber: imp. · View Herald TranscriptJun 26 2019, 4:30 PM

dim mentioned this in rS367466: Sync up elftoolchain with head, except for the capsicum-related commits,.Nov 7 2020, 11:58 PM

Revision Contents
Changeset List

Path

Size

contrib/

elftoolchain/

libelftc/

elftc_string_table.c

2 lines

Diff 59014

View Options

contrib/elftoolchain/libelftc/elftc_string_table.c

libelftc: Micro-optimize strtab insertion.ClosedPublicActions