Page MenuHomeFreeBSD
Differential D20723

Remove bad /useless S_ISBLK from swapon
ClosedPublic
Actions

Authored by dougm on Jun 22 2019, 5:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Aug 15, 9:30 PM
Unknown Object (File)
Sat, Jul 26, 2:04 AM
Unknown Object (File)
Jul 7 2025, 6:02 PM
Unknown Object (File)
Jun 24 2025, 11:51 AM
Unknown Object (File)
Jun 22 2025, 7:59 PM
Unknown Object (File)
Jun 22 2025, 3:27 PM
Unknown Object (File)
Jun 20 2025, 1:42 PM
Unknown Object (File)
Jun 19 2025, 6:08 AM
View All 71 Files
Subscribers
imp

Details

Reviewers
kib
markj
alc
Commits
rS349293: You can't use block special nodes for swap, so don't let that happen.
Summary

Kostik says it's bad, or useless. I have no opinion. Discuss.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dougm created this revision.Jun 22 2019, 5:16 PM
kib accepted this revision.Jun 22 2019, 5:37 PM

You can't use block special nodes for anything on FreeBSD. In particular, they cannot be used for swap.

This revision is now accepted and ready to land.Jun 22 2019, 5:37 PM
dougm updated this revision to Diff 58902.Jun 22 2019, 5:37 PM

I understand that I violated a style(9) header rule too. Fix that.

This revision now requires review to proceed.Jun 22 2019, 5:37 PM
kib accepted this revision.Jun 22 2019, 6:23 PM
This revision is now accepted and ready to land.Jun 22 2019, 6:23 PM
markj accepted this revision.Jun 22 2019, 7:21 PM
Closed by commit rS349293: You can't use block special nodes for swap, so don't let that happen. (authored by dougm). · Explain WhyJun 22 2019, 7:27 PM
This revision was automatically updated to reflect the committed changes.
dougm added a commit: rS349293: You can't use block special nodes for swap, so don't let that happen..
Herald added a subscriber: imp. · View Herald TranscriptJun 22 2019, 7:27 PM

Revision Contents
Changeset List

PathSize
5 lines

Diff 58902

View Options

swapon.c

Loading...