Differential D20637

Unnecessary Include Header Removal
ClosedPublic
Actions

Authored by kfv_kfv.io on Jun 14 2019, 2:16 PM.

Details

Reviewers

dteske
rgrimes
cem

Commits

rS349289: `libjail/jail.c' includes both <sys/param.h> and <sys/types.h>

Summary

`libjail/jail.c' has included both <sys/param.h> and <sys/types.h> wherein the latter is unnecessary since it's already included by <sys/param.h>.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24848
Build 23597: arc lint + arc unit

Event Timeline

kfv_kfv.io created this revision.Jun 14 2019, 2:16 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 14 2019, 2:16 PM

Harbormaster completed remote builds in B24848: Diff 58625.Jun 14 2019, 2:16 PM

I approve of this change. But since I have not committed in a while, want to get sign-off from at least one other person.

@rgrimes @cem If one of you approve, I'll go ahead and usher it in

(<sys/param.h> includes <sys/types.h>; do not include both.)

— style(9)

Macro shipit:

This revision is now accepted and ready to land.Jun 15 2019, 12:43 AM

Thanks everyone.

dteske accepted this revision.Jun 22 2019, 3:33 PM

Closed by commit rS349289: `libjail/jail.c' includes both <sys/param.h> and <sys/types.h> (authored by dteske). · Explain WhyJun 22 2019, 3:39 PM

This revision was automatically updated to reflect the committed changes.

dteske added a commit: rS349289: `libjail/jail.c' includes both <sys/param.h> and <sys/types.h>.

Revision Contents
Changeset List

Path

Size

lib/

libjail/

jail.c

1 line

Diff 58625

View Options

Unnecessary Include Header RemovalClosedPublicActions