Page MenuHomeFreeBSD
Differential D20544

strip: Provide a size hint when creating the string table.
ClosedPublic
Actions

Authored by markj on Jun 6 2019, 9:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 1:10 AM
Unknown Object (File)
Wed, Dec 4, 8:38 PM
Unknown Object (File)
Wed, Dec 4, 1:30 AM
Unknown Object (File)
Fri, Nov 29, 9:58 AM
Unknown Object (File)
Thu, Nov 28, 5:54 AM
Unknown Object (File)
Wed, Nov 27, 5:10 AM
Unknown Object (File)
Tue, Nov 26, 9:33 AM
Unknown Object (File)
Tue, Nov 26, 9:33 AM
View All Files
Subscribers
imp

Details

Reviewers
emaste
Commits
rS349423: elfcopy: Provide a size hint when creating the section string table.
Summary

Use the input file's .shstrtab size as the hint. The libelftc
default seems to be too small and we get lots of resizing and hash
collisions with the input files from PR 234949.

Test Plan

With this change we are faster than GNU strip. :)

markj@raichu> time strip ghc-8.6.2/libraries/Cabal/Cabal/dist-install/build/libHSCabal-2.4.0.1.a

real    0m2.147s
user    0m1.767s
sys     0m0.187s
markj@raichu> time /usr/local/bin/strip ghc-8.6.2/libraries/Cabal/Cabal/dist-install/build/libHSCabal-2.4.0.1.a

real    0m2.918s
user    0m2.662s
sys     0m0.166s



markj@raichu> time strip ghc-8.6.2/libraries/Cabal/Cabal/dist-install/build/libHSCabal-2.4.0.1_p.a

real    0m4.546s
user    0m4.109s
sys     0m0.204s
markj@raichu> time /usr/local/bin/strip ghc-8.6.2/libraries/Cabal/Cabal/dist-install/build/libHSCabal-2.4.0.1_p.a

real    0m4.670s
user    0m4.128s
sys     0m0.351s

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 24801
Build 23553: arc lint + arc unit

Event Timeline

markj created this revision.Jun 6 2019, 9:21 PM
Harbormaster completed remote builds in B24733: Diff 58332.Jun 6 2019, 9:21 PM
markj edited the summary of this revision. (Show Details)Jun 6 2019, 9:22 PM
markj edited the test plan for this revision. (Show Details)
markj added a reviewer: emaste.
markj updated this revision to Diff 58496.Jun 10 2019, 9:47 PM
  • Update libelftc_string_table to use size_t for the table size.
  • Don't error out if the input file does not have a shstrtab.

I plan to commit the libelftc change separately.

Harbormaster completed remote builds in B24801: Diff 58496.Jun 10 2019, 9:47 PM
markj updated this revision to Diff 58809.Jun 19 2019, 9:15 PM

Rebase.

Harbormaster completed remote builds in B24945: Diff 58809.Jun 19 2019, 9:15 PM
emaste accepted this revision.Jun 25 2019, 9:26 PM
This revision is now accepted and ready to land.Jun 25 2019, 9:26 PM
Closed by commit rS349423: elfcopy: Provide a size hint when creating the section string table. (authored by markj). · Explain WhyJun 26 2019, 4:35 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rS349423: elfcopy: Provide a size hint when creating the section string table..
Herald added a subscriber: imp. · View Herald TranscriptJun 26 2019, 4:35 PM
dim mentioned this in rS367466: Sync up elftoolchain with head, except for the capsicum-related commits,.Nov 7 2020, 11:58 PM

Revision Contents
Changeset List

PathSize
contrib/
elftoolchain/
elfcopy/
18 lines
libelftc/
8 lines
4 lines
4 lines

Diff 58496

View Options

contrib/elftoolchain/elfcopy/sections.c

Loading...
View Options

contrib/elftoolchain/libelftc/elftc_string_table.c

Loading...
View Options

contrib/elftoolchain/libelftc/elftc_string_table_create.3

Loading...
View Options

contrib/elftoolchain/libelftc/libelftc.h

Loading...